Highlight line on failed subscription sync
What does this MR do?
Relates to gitlab-org/gitlab#331597. With this MR we're updating the color of the Last sync
row to reflect whether the sync failed. In particular, it's made more explicit that the sync status is now part of the state of the application.
A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.
Local Testing
First subscription activation
-
Delete any previous license you might have
-
Make sure you have set the following environment vars (usually in your terminal) and restart
gdk
-
GITLAB_LICENSE_MODE
is set totest
-
CUSTOMER_PORTAL_URL
is set tohttps://customers.stg.gitlab.com
-
-
Use Rails console to run
ApplicationSetting.current.update(cloud_license_enabled: true)
-
Visit
Admin > Subscription
-
Use this code to activate the subscription
sVYsJcSFw4kvHBpB3mgK4469
-
To make the sync fail, block the network calls to
admin/license/sync_seat_link
Screenshots (strongly suggested)
Failure | Success (nothing changed) |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team