Skip to content

Highlight line on failed subscription sync

Angelo Gulina requested to merge ag-331597-failed-sync into master

What does this MR do?

Relates to gitlab-org/gitlab#331597. With this MR we're updating the color of the Last sync row to reflect whether the sync failed. In particular, it's made more explicit that the sync status is now part of the state of the application.

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

Local Testing

First subscription activation

  1. Delete any previous license you might have

  2. Make sure you have set the following environment vars (usually in your terminal) and restart gdk

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Visit Admin > Subscription

  5. Use this code to activate the subscription sVYsJcSFw4kvHBpB3mgK4469

  6. To make the sync fail, block the network calls to admin/license/sync_seat_link

Screenshots (strongly suggested)

Failure Success (nothing changed)
Screenshot_2021-06-01_at_11.38.35 Screenshot_2021-06-01_at_11.39.46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports