Stop migrating pages metadata on API requests
What does this MR do?
When implementing !62469 (merged) I noticed that the pipeline was failing because of tests ensuring that we return pages path for projects with not yet migrated metadata.
It made sense when we originally rolling out API because we didn't know when migration was actually finished(we could wait for .com to finish and enable API only after this though).
But in 14.0 we actually disabling serving from legacy storage by default anyway, and the only way to enable will be to use use_legacy_storage flag, which will disable API, and it doesn't matter what API returns.
So we can simply stop migrating pages metadata mid-flight.
Note: I didn't delete the background migration and the corresponding index introduced in 817c140e because I still want to allow this migration to finish if people upgrade directly from 12.0 to 14.0, pages content might not be migrated automatically this way, but admins can at least run the rake task which relies on the existence of metadata
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team