Remove support for legacy storage in pages API
What does this MR do?
See omnibus-gitlab#5993 (closed)
If use_legacy_storage is set to true omnibus-gitlab!5265 (merged) will actually set domain-config-source to disk on GitLab Pages side, so the daemon will stop requesting the API. So it doesn't matter what rails return in the API.
Originally I added use_legacy_storage to allow API to return legacy_storage, but then I realized that we can just remove support for it altogether. Before 14.0 you could configure:
domain-config-source=gitlab- legacy storage enabled on rails
In that case daemon would request API and receive disk path.
Starting from 14.0 you can only completely disable the new architecture(including the API) - we leave this option to give users some time to transition to the new architecture if they face some complex problem
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to gitlab-pages#1071 (closed)