Skip to content

Audit and update buttons on Projects::BranchesController#index"

What does this MR do?

Updates the buttons in Projects::BranchesController#index:

  • Use btn-icon variant for delete buttons.
  • Reduce space between buttons in rows from 10px to 8px.
  • Align inline dropdown to the top of the other buttons.
  • Update inline dropdown icon colors.

Screenshots

Before After
CleanShot_2021-05-14_at_07.25.16 CleanShot_2021-05-14_at_11.14.48
CleanShot_2021-05-14_at_07.28.58 (1) This fix is happening in !61413 (merged), see this diff.
CleanShot_2021-05-14_at_10.51.28 CleanShot_2021-05-14_at_11.12.52
CleanShot_2021-05-14_at_10.52.06 CleanShot_2021-05-14_at_11.04.46

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273303 (closed)

Edited by Jeremy Elder

Merge request reports