Skip to content

Audit and update buttons on Projects::TagsController#index"

What does this MR do?

Update buttons on the Projects::TagsController#index to align with Pajamas.

  • Fix broken wrapping.
  • Adjust breakpoints.
  • Use consistent spacing.
  • Use correct order.
  • Update danger variant to default. This is because a) the trash button leads to an interstitial so is not destructive itself (the button in the modal does use the danger variant), and b) the presence of so many primary danger buttons overwhelms the primary "New tag" action.

Out of scope

  • Changing the "Unverified" anchor into a badge.
  • Updating flexbox column-reverse in the header area to have DOM order match reading order. This impacts many pages.
  • Updating flexbox layout settings in general for both the header and list buttons.
  • Updating the .nav-text line height. There is a .multi-line class that could be applied, but in testing it had other negative impacts. Since this is used elsewhere, changing the 28px line height could break alignment in other places these styles are used.
  • Row of buttons when viewing a single tag's page.

Screenshots

Before After
gdk.test_3003_gitlab-org_gitlab-test_-tags__6 gdk.test_3003_gitlab-org_gitlab-test_-tags__1
gdk.test_3003_gitlab-org_gitlab-test_-tags__5 gdk.test_3003_gitlab-org_gitlab-test_-tags__2
gdk.test_3003_gitlab-org_gitlab-test_-tags__4 gdk.test_3003_gitlab-org_gitlab-test_-tags__3
gdk.test_3003_gitlab-org_gitlab-test_-_tags_new gdk.test_3003_gitlab-org_gitlab-test_-tags_new__1
gdk.test_3003_gitlab-org_gitlab-test_-_tags_v1.1.1_release_edit gdk.test_3003_gitlab-org_gitlab-test_-_tags_v1.1.0_release_edit

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273322 (closed)

Edited by Jeremy Elder

Merge request reports