Audit and update buttons on Projects::TagsController#index"
requested to merge 273322-fy21q4-foundations-kr2-audit-and-update-buttons-on-projects-tagscontroller-index into master
What does this MR do?
Update buttons on the Projects::TagsController#index to align with Pajamas.
- Fix broken wrapping.
- Adjust breakpoints.
- Use consistent spacing.
- Use correct order.
- Update danger variant to default. This is because a) the trash button leads to an interstitial so is not destructive itself (the button in the modal does use the danger variant), and b) the presence of so many primary danger buttons overwhelms the primary "New tag" action.
Out of scope
- Changing the "Unverified" anchor into a badge.
- Updating flexbox
column-reverse
in the header area to have DOM order match reading order. This impacts many pages. - Updating flexbox layout settings in general for both the header and list buttons.
- Updating the
.nav-text
line height. There is a.multi-line
class that could be applied, but in testing it had other negative impacts. Since this is used elsewhere, changing the28px
line height could break alignment in other places these styles are used. - Row of buttons when viewing a single tag's page.
Screenshots
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
I have included a changelog entry, or it's not needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #273322 (closed)
Edited by Jeremy Elder