Skip to content
Snippets Groups Projects

Enable the improved emoji picker by default

Merged Phil Hughes requested to merge ph/enableImprovedEmojiPicker into master
All threads resolved!

What does this MR do?

Enables the improved emoji picker by default

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 4 Warnings
    :warning: 072fd158: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: This merge request changed files with disabled eslint rules. Please consider fixing them.
    :warning: Please add a merge request type to this merge request.
    :warning: This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.
    1 Message
    :book: We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach.

    To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a Changelog trailer to it. For example:

    This is my commit's subject line
    
    This is the optional commit body.
    
    Changelog: added

    The value of the Changelog trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.

    For more information, take a look at the following resources:

    If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.

    Disabled eslint rules

    The following files have disabled eslint rules. Please consider fixing them:

    • app/assets/javascripts/awards_handler.js

    Run the following command for more details

    node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
      'app/assets/javascripts/awards_handler.js'

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    frontend Scott Stern (@sstern) (UTC-7, 8 hours behind @iamphill) Nicolò Maria Mezzopera (@nmezzopera) (UTC+2, 1 hour ahead of @iamphill)
    test Quality for spec/features/* Allison Browne (@allison.browne) (UTC-4, 5 hours behind @iamphill) Maintainer review is optional for test Quality for spec/features/*

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Phil Hughes added 1 commit

    added 1 commit

    • 5d0cefdd - Enable the improved emoji picker by default

    Compare with previous version

  • Phil Hughes added 1 commit

    added 1 commit

    • 072fd158 - Enable the improved emoji picker by default

    Compare with previous version

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 73f2dfc3 and acbdd75a

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.18 MB 3.18 MB - 0.0 %
    mainChunk 1.92 MB 1.92 MB - 0.0 %

    Note: We do not have exact data for 73f2dfc3. So we have used data from: 9cac39f3.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Phil Hughes requested review from @kushalpandya

    requested review from @kushalpandya

  • Kushal Pandya approved this merge request

    approved this merge request

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya added 1 commit

    added 1 commit

    • acbdd75a - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Kushal Pandya enabled an automatic merge when the pipeline for 7b814772 succeeds

    enabled an automatic merge when the pipeline for 7b814772 succeeds

  • merged

  • Kushal Pandya mentioned in commit c18d02a4

    mentioned in commit c18d02a4

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • @iamphill do we need to update any documentation for this feature? :thinking:

  • Lukas Eipert mentioned in issue #331996

    mentioned in issue #331996

  • euko mentioned in merge request !138892 (merged)

    mentioned in merge request !138892 (merged)

  • Please register or sign in to reply
    Loading