There was an error fetching the job.
danger-review
Passed Started
by
@kushalpandya

Kushal Pandya
1Running with gitlab-runner 13.12.0-rc1 (b21d5c5b)2 on prm-com-gitlab-org bd0915563 feature flags: FF_USE_FASTZIP:true, FF_GITLAB_REGISTRY_HELPER_IMAGE:true, FF_SKIP_DOCKER_MACHINE_PROVISION_ON_CREATION_FAILURE:true6Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...7Authenticating with credentials from job payload (GitLab Registry)8Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 ...9Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...11Running on runner-bd091556-project-278964-concurrent-0 via runner-bd091556-prm-1620896969-b5b2d831...13$ eval "$CI_PRE_CLONE_SCRIPT"14Downloading archived master...15Connecting to storage.googleapis.com (172.217.193.128:443)16saving to '/tmp/gitlab.tar.gz'17gitlab.tar.gz 51% |**************** | 220M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 425M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24remote: Enumerating objects: 400, done. 25remote: Counting objects: 100% (251/251), done. 26remote: Compressing objects: 100% (95/95), done. 27remote: Total 124 (delta 90), reused 53 (delta 29), pack-reused 0 28Receiving objects: 100% (124/124), 24.17 KiB | 2.68 MiB/s, done.29Resolving deltas: 100% (90/90), completed with 62 local objects.31 * [new ref] 7b81477283b9ca416e52cef18b704357176fcd8f -> refs/pipelines/30231760532Checking out 7b814772 as refs/merge-requests/61384/merge...33Skipping Git submodules setup35Checking cache for danger-review-v1-4...36Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/danger-review-v1-4 37Successfully extracted cache39Using docker image sha256:9b06bf3dd0ab8d484e8c9e9c611f75eab098939f568d587a7fd23a3c96eceb87 for registry.gitlab.com/gitlab-org/gitlab-build-images:ruby-2.7.2.patched-golang-1.14-git-2.31-lfs-2.9-chrome-89-node-14.15-yarn-1.22-postgresql-11-graphicsmagick-1.3.36 with digest registry.gitlab.com/gitlab-org/gitlab-build-images@sha256:eb4fdeb3196481dd022d7d166468834e40a046b46a29e3349fb3bf3657176290 ...40$ source ./scripts/utils.sh41$ run_timed_command "bundle install --jobs=$(nproc) --path=vendor --retry=3 --quiet --with danger"42$ bundle install --jobs=2 --path=vendor --retry=3 --quiet --with danger43[DEPRECATED] The `--with` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set with 'danger'`, and stop using this flag44==> 'bundle install --jobs=2 --path=vendor --retry=3 --quiet --with danger' succeeded in 1 seconds.45$ run_timed_command "retry yarn install --frozen-lockfile"46$ retry yarn install --frozen-lockfile47yarn install v1.22.1048[1/5] Validating package.json...49[2/5] Resolving packages...50success Already up-to-date.51$ node ./scripts/frontend/postinstall.js52success Dependency postinstall check passed.53Done in 1.07s.54==> 'retry yarn install --frozen-lockfile' succeeded in 2 seconds.55$ if [ -z "$DANGER_GITLAB_API_TOKEN" ]; then # collapsed multi-line command56$ bundle exec danger --fail-on-errors=true --verbose57danger/feature_flag/Dangerfile:4: warning: already initialized constant Danger::Dangerfile::SEE_DOC58danger/changelog/Dangerfile:6: warning: previous definition of SEE_DOC was here59danger/feature_flag/Dangerfile:7: warning: already initialized constant Danger::Dangerfile::SUGGEST_MR_COMMENT60danger/changelog/Dangerfile:8: warning: previous definition of SUGGEST_MR_COMMENT was here61danger/roulette/Dangerfile:5: warning: already initialized constant Danger::Dangerfile::MESSAGE62danger/pipeline/Dangerfile:3: warning: previous definition of MESSAGE was here63Results:64Warnings:65- [ ] 072fd158123a6b0f659e3a4c37d9321f7341403f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our [Commit message guidelines](https://docs.gitlab.com/ee/development/contributing/merge_request_workflow.html#commit-messages-guidelines).66- [ ] This merge request changed files with disabled eslint rules. Please consider fixing them.67- [ ] Please add a [merge request type](https://about.gitlab.com/handbook/engineering/metrics/#data-classification) to this merge request.68- [ ] This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time.69Messages:70- [ ] We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach.71To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a `Changelog` trailer to it. For example:72```73This is my commit's subject line74This is the optional commit body.75Changelog: added76```77The value of the `Changelog` trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other.78For more information, take a look at the following resources:81If you'd like to see the new approach in action, take a look at the commits in [the Omnibus repository](https://gitlab.com/gitlab-org/omnibus-gitlab/-/commits/master).82Markdown:83## Disabled eslint rules84The following files have disabled `eslint` rules. Please consider fixing them:85* `app/assets/javascripts/awards_handler.js`86Run the following command for more details87```88node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \89 'app/assets/javascripts/awards_handler.js'90```91## Reviewer roulette92Changes that require review have been detected! A merge request is normally93reviewed by both a reviewer and a maintainer in its primary category (e.g.94~frontend or ~backend), and by a maintainer in all other categories.95To spread load more evenly across eligible reviewers, Danger has picked a candidate for each96review slot, based on their timezone. Feel free to97[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)98if you think someone else would be better-suited99or use the [GitLab Review Workload Dashboard](https://gitlab-org.gitlab.io/gitlab-roulette/) to find other available reviewers.100To read more on how to use the reviewer roulette, please take a look at the101[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)102and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).103Please consider assigning a reviewer or maintainer who is a104[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.105Once you've decided who will review this merge request, assign them as a reviewer!106Danger does not automatically notify them for you.107| Category | Reviewer | Maintainer |108| -------- | -------- | ---------- |109| ~frontend | [Scott Stern](https://gitlab.com/sstern) (`@sstern`) (UTC-7, 8 hours behind `@iamphill`) | [Nicolò Maria Mezzopera](https://gitlab.com/nmezzopera) (`@nmezzopera`) (UTC+2, 1 hour ahead of `@iamphill`) |110| ~test ~Quality for `spec/features/*` | [Allison Browne](https://gitlab.com/allison.browne) (`@allison.browne`) (UTC-4, 5 hours behind `@iamphill`) | Maintainer review is optional for ~test ~Quality for `spec/features/*` |111**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/1259984479) that generated this comment.**112==> 'bundle exec danger --fail-on-errors=true --verbose' succeeded in 6 seconds.114Not uploading cache danger-review-v1-4 due to policy116Job succeeded