Skip to content

Adding initial tracking for file size highlight limits [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Gary Holtz requested to merge 31065-gmh-add-size-over-metrics into master

What does this MR do?

GitLab will only highlight text if it is under a certain file size. The default value is 512kb, but that can be configured in the gitlab.yml file. (see: !60445 (merged) )

For #31065, we are trying to decide if that is the best number to have as a default. To figure that out, we need some metrics:

This MR will introduce a feature flag track_file_size_over_highlight_limit that, when enabled, will increment a metric each time we go over the file size configured in Gitlab.config.extra['maximum_text_highlight_size_kilobytes'].

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #31065

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading