Adding initial tracking for file size highlight limits [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

GitLab will only highlight text if it is under a certain file size. The default value is 512kb, but that can be configured in the gitlab.yml file. (see: !60445 (merged) )

For #31065, we are trying to decide if that is the best number to have as a default. To figure that out, we need some metrics:

This MR will introduce a feature flag track_file_size_over_highlight_limit that, when enabled, will increment a metric each time we go over the file size configured in Gitlab.config.extra['maximum_text_highlight_size_kilobytes'].

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

• 📋 Does this MR need a changelog?
  • I have included a changelog entry.
  • I have not included a changelog entry because this is behind a feature flag.
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Related to #31065

changed milestone to %13.12

added Application Limits Category:Code Review Workflow Deliverable OKR FY22 Q2Large MR backend backstage [DEPRECATED] devopscreate groupcode review sectiondev typefeature workflowin review labels

Hey @garyh, backstage [DEPRECATED] is being deprecated in favor of featureaddition, ~"feature::maintenance", ~"tooling::pipelines", and ~"tooling::workflow" to improve the identification of these type of changes. Please see https://about.gitlab.com/handbook/engineering/metrics/#data-classification for further guidance.

removed backstage [DEPRECATED] label

added 1 commit

• e51a3c72 - Adding initial tracking for file size highlight limits

Compare with previous version

added 1 commit

• b9ac94c8 - Adding MR name to feature flag

Compare with previous version

changed title from Adding initial tracking for file size highlight limits to Adding initial tracking for file size highlight limits [RUN ALL RSPEC] [RUN AS-IF-FOSS]

added feature flag label

	3 Messages
📖	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following: bin/changelog -m 61273 "Adding initial tracking for file size highlight limits [RUN ALL RSPEC] [RUN AS-IF-FOSS]" If you want to create a changelog entry for GitLab EE, run the following instead: bin/changelog --ee -m 61273 "Adding initial tracking for file size highlight limits [RUN ALL RSPEC] [RUN AS-IF-FOSS]" If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖	We are in the process of rolling out a new workflow for adding changelog entries. This new workflow uses Git commit subjects and Git trailers to generate changelogs. This new approach will soon replace the current YAML based approach. To ease the transition process, we recommend you start using both the old and new approach in parallel. This is not required at this time, but will make it easier to transition to the new approach in the future. To do so, pick the commit that should go in the changelog and add a Changelog trailer to it. For example: This is my commit's subject line This is the optional commit body. Changelog: added The value of the Changelog trailer should be one of the following: added, fixed, changed, deprecated, removed, security, performance, other. For more information, take a look at the following resources: https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/1564 https://docs.gitlab.com/ee/api/repositories.html#generate-changelog-data If you'd like to see the new approach in action, take a look at the commits in the Omnibus repository.
📖	You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS] (we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Marc Shaw (@marc_shaw) (UTC+12, 17 hours ahead of @garyh)	James Lopez (@jameslopez) (UTC+2, 7 hours ahead of @garyh)

If needed, you can retry the danger-review job that generated this comment.

Generated by 🚫 Danger

mentioned in merge request !61274 (merged)

assigned to @garyh

@pedropombeiro Hi Pedro! Sorry to bother you again, but would you mine reviewing this one as well (since you did !60956 (merged) and it's fairly similar 😄 )

requested review from @pedropombeiro

approved this merge request

requested review from @lulalala and removed review request for @pedropombeiro

approved this merge request

resolved all threads

enabled an automatic merge when the pipeline for 3a19fd51 succeeds