Skip to content

Add initial highlight timeout metrics behind a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Gary Holtz requested to merge 31065-gmh-add-highlight-timeout-metrics into master

What does this MR do?

Right now, GitLab will only highlight text if it is under a total file size of 512kb. (Although this will be configurable after !60445 (merged) )

For #31065, we are trying to figure out if that is the best number to have as a default. To figure that out, we need some metrics.

This MR will introduce a feature flag track_highlight_timeouts that, when enabled, will increment the following metrics each time highlighting times out:

  • :highlight_timeout -> :foreground - for normal operations
  • :highlight_timeout -> :background - for highlighting done in Sidekiq

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #31065

Edited by 🤖 GitLab Bot 🤖

Merge request reports