Skip to content

Subscription Activation Modal: Modal Component + History Mutation

What does this MR do?

This MR is part of a larger work towards implementing the feature described in gitlab-org/gitlab#328246. In this MR we're plugging the modal and adding the update to the subscription list when the activation (mutation) completes.

Additionally, to make the code more testable, we're extracting some of the logic.

Failing scenarios were handled in the previous MRs.

Use the mutation data to update the current subscription !60577 (merged)
Generalise Activation Form !60628 (merged)
Create the modal reusing the Activation Form !60819 (merged)
Plug the Activation Modal and add the mutation for the subscription list 👈 you are here
Write feature specs tbd

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

To test the changes locally

  1. Delete any previous license you might have

  2. Make sure you have set the following environment vars (usually in your terminal) and restart gdk

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Navigate to admin/cloud_license

  5. Use the following activation code: Lx6XhhLR1jSj2aacuZFRP8Mf

  6. To test the failing scenario (connectivity Issue), set CUSTOMER_PORTAL_URL to https://fakeaddress and proceed with the activation.

Screenshots (strongly suggested)

Activation
Screen_Recording_2021-05-04_at_15.57.08
Genreal Error Connectivity Error
Screenshot_2021-05-03_at_17.32.56 Screenshot_2021-05-03_at_17.35.12

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports