Skip to content

Subscription Activation Modal: Generalise Activation Form

What does this MR do?

This MR is part of a larger work towards implementing the feature described in gitlab-org/gitlab#328246. In this MR we're moving the Subscription Activation Form Card to its own component so that the Form can be later re-used in the Modal. Plus, the communication between the components and the tests accordingly.

The modal won't be plugged though because of an ongoing conversation regarding some of the conditions to show the button that would trigger it (if interested, see here)

The failing scenarios are handled in the context of this issue and, for the modal, of the following ones.

Use the mutation data to update the current subscription !60577 (merged)
Generalise Activation Form 👈 you are here
Create the modal reusing the Activation Form tbd
Plug the Activation Modal and add the mutation for the subscription list tbd
Write feature specs tbd

A feature flag is not used because this feature is for self-managed instances. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

To test the changes locally

  1. Delete any previous license you might have

  2. Make sure you have set the following environment vars (usually in your terminal) and restart gdk

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Navigate to admin/cloud_license

  5. Use the following activation code: Lx6XhhLR1jSj2aacuZFRP8Mf

  6. To test the failing scenario (connectivity Issue), set CUSTOMER_PORTAL_URL to https://fakeaddress and proceed with the activation.

Screenshots (strongly suggested)

There are no UI changes in this MR.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports

Loading