Subscription Activation: Fix Subscription Form UX
What does this MR do?
This MR is tweaking the UI/UX for the Subscription Activation Form in order to adhere to the designer's recommendations. The failing scenarios are handled in the context of this issue
A feature flag is not used because this feature is for self-managed instances.. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.
To test the changes locally
-
Delete any previous license you might have
-
Make sure you have set the following vars
-
GITLAB_LICENSE_MODE
is set totest
-
CUSTOMER_PORTAL_URL
is set tohttps://customers.stg.gitlab.com
-
-
Use Rails console to run
ApplicationSetting.current.update(cloud_license_enabled: true)
-
Navigate to
admin/cloud_license
Screenshots (strongly suggested)
All invalid | Invalid checkbox | Invalid Input | Valid |
---|---|---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because the feature is not released to the public.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina