Skip to content

Subscription Activation: Fix Subscription Form UX

Angelo Gulina requested to merge ag-fix-activation-ux into master

What does this MR do?

This MR is tweaking the UI/UX for the Subscription Activation Form in order to adhere to the designer's recommendations. The failing scenarios are handled in the context of this issue

A feature flag is not used because this feature is for self-managed instances.. The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

To test the changes locally

  1. Delete any previous license you might have

  2. Make sure you have set the following vars

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Navigate to admin/cloud_license

Screenshots (strongly suggested)

All invalid Invalid checkbox Invalid Input Valid
Screenshot_2021-04-27_at_12.27.38 Screenshot_2021-04-27_at_12.27.44 Screenshot_2021-04-27_at_12.32.32 Screenshot_2021-04-27_at_12.27.48

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports