Skip to content

Manual Sync: add feature specs

Angelo Gulina requested to merge ag-325156-manual-sync-specs into master

What does this MR do?

This is a 4 steps MR, tackling gitlab-org/gitlab#325156. This step is adding the feature specs to account for the syncing (success/failing) scenario.

1 frontend to add the alerts and display logic !59647 (merged)
2 frontend to show the sync button and connect with backend !59612 (merged)
3 frontend write specs 👈 you are here
4 backend to modify the response from the sync endpoint !59532 (merged)

The feature is behind an Application Setting and it's not released nor documented. To test it locally, see the following steps.

To test the changes locally

  1. Delete any previous license you might have

  2. Make sure you have set the following vars

    • GITLAB_LICENSE_MODE is set to test
    • CUSTOMER_PORTAL_URL is set to https://customers.stg.gitlab.com
  3. Use Rails console to run ApplicationSetting.current.update(cloud_license_enabled: true)

  4. Navigate to admin/cloud_license

  5. Use the following activation code: Lx6XhhLR1jSj2aacuZFRP8Mf

  6. To test the failing scenario, simply block the network request to sync_seat_link

Note: ~~the backend part is pending review. The interaction between the 2 will be covered by feature specs~~.

Screenshots (strongly suggested)

Screenshots are provided only for reference. No UI is changed with this MR.

Cloud License Legacy License
Screenshot_2021-04-21_at_08.53.27 Screenshot_2021-04-21_at_08.40.51
Sync Subscription Success Sync Subscription Success Dismiss
Screen_Recording_2021-04-21_at_07.39.16 Screen_Recording_2021-04-21_at_07.39.30
Sync Subscription Failure Sync Subscription Retry (and Success)
Screen_Recording_2021-04-21_at_07.39.55 Screen_Recording_2021-04-21_at_07.40.12

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports