Skip to content

Manual Sync: Add Alert Notifications

Angelo Gulina requested to merge ag-325156-manual-sync-alert into master

What does this MR do?

This is a 4 steps MR, tackling gitlab-org/gitlab#325156. The backend implementation was already done but given the frontend requirements have changed, there's gonna be some updates from the backend as well.

In this MR we introduce a component responsible to handle the user notifications for successful or failing (manual) sync. The component will be plugged into the main app in the scope of the second step.

The feature is behind an Application setting. Steps to test locally are provided below.

1 frontend to add the alerts and display logic 👈 you are here
2 frontend to show the sync button and connect with backend tbd
3 frontend write specs tbd
4 backend to modify the response from the sync endpoint tbd

To test the changes locally

  1. Use Rails console to run:
ApplicationSetting.current.update(cloud_license_enabled: true)
  1. Use the following patch:
  1. Navigate to admin/cloud_license

Screenshots (strongly suggested)

Idle Sync success Sync failure
Screenshot_2021-04-19_at_15.36.40 Screenshot_2021-04-19_at_13.10.51 Screenshot_2021-04-19_at_15.39.10

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports