Render grid as single timeline cell and update day indicator
requested to merge oncall-schedule-timeline-4-grid-single-timeframe into oncall-schedule-timeline-3-code-consolodate
What does this MR do?
A small MVC for: #324608 (closed) where we render the entire grid as a single cell rather than multiple cells in the weekly layout to ensure the position calculations work correctly.
Merge train
This MR is part of the on-call schedule merge train. It is one step in an overall effort to allow more detailed shifts to be displayed accurately. Full details in this issue: #324608 (closed)
| What | Merge | You are here |
|---|---|---|
| Introduce new helper for shift utils | !58202 (merged) | |
| Update shift width query | !58204 (merged) | |
| Consolidate Week and Day shift items | !58322 (merged) | |
| Render grid as single timeline cell and update day indicator | !58342 (merged) | |
| Remove old code | !58352 (merged) | |
| Update / Add specs | !58436 (merged) |
All changes are consolidated in a sandbox MR here: !57300 (closed)
Screenshots (strongly suggested)
| Week | Day |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because no visual change.
-
- [n/a] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [n/a] Database guides
- [n/a] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [n/a] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [n/a] Label as security and @ mention
@gitlab-com/gl-security/appsec - [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [n/a] Security reports checked/validated by a reviewer from the AppSec team
issue: #324608 (closed)
Edited by Tristan Read