Skip to content

Oncall schedule consolidate day and week code

What does this MR do?

A tiny MVC for: #324608 (closed) where we consolidate the overlapping code between the day/week schedule items.

Merge train

This MR is part of the on-call schedule merge train. It is one step in an overall effort to allow more detailed shifts to be displayed accurately. Full details in this issue: #324608 (closed)

What Merge You are here
Introduce new helper for shift utils !58202 (merged) 🚫
Update shift width query !58204 (merged) 🚫
Consolidate Week and Day shift items !58322 (merged) 🤘
Render grid as single timeline cell and update day indicator !58342 (merged) 🚫
Remove old code !58352 (merged) 🚫
Update / Add specs !58436 (merged) 🚫

All changes are consolidated in a sandbox MR here: !57300 (closed)

Screenshots (strongly suggested)

Week Day
Screenshot_2021-04-01_at_08.04.36 Screenshot_2021-04-01_at_08.11.18

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team

issue: #324608 (closed)

Edited by Tristan Read

Merge request reports