Skip to content

Add new oncall schedule timeline width query

What does this MR do?

  • Add a new graphql client query to calculate the timeline width.
  • Use the new utils to calculate the correct shift width.
  • Update existing specs.
  • Add new specs.

Merge train

This MR is part of the on-call schedule merge train. It is one step in an overall effort to allow more detailed shifts to be displayed accurately. Full details in this issue: #324608 (closed)

  1. Introduce new helper for shift utils
  2. Update shift width query <--- You are here!
  3. Consolidate Week and Day shift items
  4. Render grid as single timeline cell and update day indicator
  5. Remove old code & add integration spec
  6. Update on-call test suite

All changes are consolidated in a sandbox MR here: !57300 (closed)

Screenshots (strongly suggested)

before after
Screenshot_2021-04-01_at_14.01.10 Screenshot_2021-04-01_at_14.48.55

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team

issue: #324608 (closed)

Edited by Tristan Read

Merge request reports