Allow Email Replies to Notes to Create Discussions
What does this MR do?
By including the discussion IDs of indivudal note discussions, which are
notes that can be turned into discussions but haven't yet, in the
X-Gitlab-Discussion-ID
header for mail clients, replies to individual
notes will convert the note to a disucssion, preserving comment
threading, instead of creating a top level note.
This makes an email reply look more like a reply than another top-level note.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added backend label
3 Warnings This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.d6343366: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Saikat Sarkar ( @ssarka
) (UTC-6, 2 hours behind@afontaine
)Stan Hu ( @stanhu
) (UTC-7, 3 hours behind@afontaine
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added grouprelease [DEPRECATED] label
added 1 commit
- 837e6223 - Allow Email Replies to Notes to Create Discussions
added 1190 commits
-
837e6223...067abf4f - 1189 commits from branch
master
- ef202932 - Allow Email Replies to Notes to Create Discussions
-
837e6223...067abf4f - 1189 commits from branch
mentioned in merge request !25389 (merged)
- Resolved by Heinrich Lee Yu
@engwan I was wondering if you'd be interested in assisting me here in allowing email replies to create discussions, as it just seems more appropriate somehow and would love to get your thoughts.
added 1 commit
- f7dc3405 - Allow Email Replies to Notes to Create Discussions
added 1040 commits
-
f7dc3405...5f62cd3e - 1038 commits from branch
master
- d0b0c887 - Allow Email Replies to Notes to Create Discussions
- 5bec27ee - Fix failing specs
-
f7dc3405...5f62cd3e - 1038 commits from branch
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
- Resolved by Heinrich Lee Yu
@afontaine I pushed up a commit that would probably fix the specs and left some comments about the change.
I'll be out the rest of the week so I'll get back to this next week if you still need some help.
Setting label(s) ~"devops::release" sectionops based on ~"group::release".
added devopsrelease [DEPRECATED] sectionops labels
mentioned in commit 194955d6
requested review from @engwan
- Resolved by Heinrich Lee Yu
changed milestone to %13.11
added featureenhancement typefeature labels
enabled an automatic merge when the pipeline for 7b1ad08c succeeds
Thanks @afontaine, looks good to me
mentioned in commit b17c41f4
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
Thanks again @engwan!
added releasedcandidate label