Skip to content

Allow Email Replies to Notes to Create Discussions

Andrew Fontaine requested to merge afontaine/make-discussions-from-emails into master

What does this MR do?

By including the discussion IDs of indivudal note discussions, which are notes that can be turned into discussions but haven't yet, in the X-Gitlab-Discussion-ID header for mail clients, replies to individual notes will convert the note to a disucssion, preserving comment threading, instead of creating a top level note.

This makes an email reply look more like a reply than another top-level note.

Screenshots (strongly suggested)


Does this MR meet the acceptance criteria?


Availability and Testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports