Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43,102
    • Issues 43,102
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,356
    • Merge requests 1,356
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !56711

Allow Email Replies to Notes to Create Discussions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrew Fontaine requested to merge afontaine/make-discussions-from-emails into master Mar 15, 2021
  • Overview 27
  • Commits 6
  • Pipelines 10
  • Changes 7

What does this MR do?

By including the discussion IDs of indivudal note discussions, which are notes that can be turned into discussions but haven't yet, in the X-Gitlab-Discussion-ID header for mail clients, replies to individual notes will convert the note to a disucssion, preserving comment threading, instead of creating a top level note.

This makes an email reply look more like a reply than another top-level note.

Screenshots (strongly suggested)

<image

Does this MR meet the acceptance criteria?

Conformity

  • 📋 Does this MR need a changelog?
    • I have included a changelog entry.
    • I have not included a changelog entry because _____.
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Mar 30, 2021 by Heinrich Lee Yu
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: afontaine/make-discussions-from-emails