Skip to content
Snippets Groups Projects

Allow Email Replies to Notes to Create Discussions

Merged Andrew Fontaine requested to merge afontaine/make-discussions-from-emails into master
All threads resolved!

What does this MR do?

By including the discussion IDs of indivudal note discussions, which are notes that can be turned into discussions but haven't yet, in the X-Gitlab-Discussion-ID header for mail clients, replies to individual notes will convert the note to a disucssion, preserving comment threading, instead of creating a top level note.

This makes an email reply look more like a reply than another top-level note.

Screenshots (strongly suggested)

<image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Setting label(s) ~"devops::release" sectionops based on ~"group::release".

  • Andrew Fontaine mentioned in commit 194955d6

    mentioned in commit 194955d6

  • Andrew Fontaine added 2 commits

    added 2 commits

    • 194955d6 - Disable RSpec/AnyInstanceOf Check for Spec
    • 9caf10b2 - Only Add Discussion ID a Note Can Have one

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Andrew Fontaine requested review from @engwan

    requested review from @engwan

  • added 1 commit

    Compare with previous version

  • Heinrich Lee Yu changed milestone to %13.11

    changed milestone to %13.11

  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Heinrich Lee Yu resolved all threads

    resolved all threads

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 7b1ad08c succeeds

    enabled an automatic merge when the pipeline for 7b1ad08c succeeds

  • Thanks @afontaine, looks good to me :thumbsup:

  • Heinrich Lee Yu mentioned in commit b17c41f4

    mentioned in commit b17c41f4

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Author Maintainer

    Thanks again @engwan! :rocket:

  • Please register or sign in to reply
    Loading