Skip to content
Snippets Groups Projects

Allow Email Replies to Notes to Create Discussions

Merged Andrew Fontaine requested to merge afontaine/make-discussions-from-emails into master
  1. Apr 16, 2021
  2. Apr 15, 2021
  3. Mar 30, 2021
    • Heinrich Lee Yu's avatar
      Fix failing specs · 5bec27ee
      Heinrich Lee Yu authored
      When transforming notes, we do some extra permissions checks so we need
      to enable service desk before creating the SentNotification
      Verified
      5bec27ee
    • Andrew Fontaine's avatar
      Allow Email Replies to Notes to Create Discussions · d0b0c887
      Andrew Fontaine authored and Heinrich Lee Yu's avatar Heinrich Lee Yu committed
      By including the discussion IDs of indivudal note discussions, which are
      notes that can be turned into discussions but haven't yet, in the
      `X-Gitlab-Discussion-ID` header for mail clients, replies to individual
      notes will convert the note to a disucssion, preserving comment
      threading, instead of creating a top level note.
      
      This makes an email reply look more like a reply than another top-level
      note.
      Verified
      d0b0c887
Loading