Skip to content

Project Settings Operations h4 Expand/Collapse 4/5

What does this MR do?

This MR adds classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only to the h4 headers in Project Settings / Operations header Metrics dashboard. This enables the expand/collapse behavior on mouse-click / tap for the h4 headers.

Related to issue #205484 reported by @djannotta, and my previous MR !54114 (merged), !54115 (merged), !54117 (merged), !55228 (merged), !55229 (merged), !55230 (merged), !55231 (merged), !55232 (merged), !55233 (merged), !55234 (merged), !55235 (merged).

Project Settings Operations Headers (h4 elements) expand/collapse on mouse-click / tap, like using the Expand/Collapse button. Other h4 headers in other Project Settings pages do not expand/collapse on mouse-click / tap, but only using the Expand/Collapse button. This may seem inconsistent to the user.

The h4 headers of Project Settings General get the expand/collapse behavior through classes settings-title, js-settings-toggle and js-settings-toggle-trigger-only.

Screenshots (strongly suggested)

(Copied from my first related MR !55228 (merged) for simplicity.)

Current behavior: no on-click / on-tap expand/collapse

project-settings-cicd-01

Behavior after applying this MR: on-click / on-tap expand/collapse

project-settings-cicd-02 project-settings-cicd-03 project-settings-cicd-04

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Daniel Schömer

Merge request reports