Project Settings CI/CD Variables Header Expand/Collapse [3/3]
What does this MR do?
Project Settings General Headers (h4 elements) expand/collapse on
mouse-click / tap, like using the Expand/Collapse button. Other h4
headers in other Project Settings pages do not expande/collapse on
mouse-click / tap, but only using the Expand/Collapse button. This may
seem inconsistent to the user.
The h4 headers of Project Settings General get the expand/collapse
behavior through classes settings-title, js-settings-toggle and
js-settings-toggle-trigger-only.
This MR adds classes settings-title, js-settings-toggle and
js-settings-toggle-trigger-only to the h4 header of Project Settings
CI/CD Variables for GitLab FOSS. This enables the expand/collapse
behavior on mouse-click / tap for the h4 headers.
This is part 3 of a series of 3 MR.
- Part 1: !54114 (merged)
- Part 2: !54115 (merged)
- Part 3: !54117 (merged) (this MR)
Screenshots (strongly suggested)
Please see screenshots in MR !54114 (merged).
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #205484