Fix code quality report comparer
Ref: #322780 (closed)
What does this MR do?
This MR refactors our CodequalityReportsComparer
.
As brought up by @mfluharty :
Will
base_report
ever benil
here if we initialize it asCodequalityReports.new
when it'snil
atcodequality_reports_comparer.rb:8
?
We forgot to remove this behaviour in our previous MR which makes it impossible to return a not_found
status to the frontend.
Why are we doing this?
After enabling our new comparison logic on the backend we realized that in some cases we don't have a base report from which to compare with our head pipeline.
This MR marks our new status
response as not_found
so we can inform the frontend that no base report has been found.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team