Skip to content

Fix codequality empty base report

Max Orefice requested to merge mo-fix-codequality-base-report into master

What does this MR do?

This MR refactors our codequality report comparison logic.

Why are we doing this?

After enabling our new comparison logic on the backend we realized that in some cases we don't have a base report from which to compare with our head pipeline.

This MR marks our new status response as not_found so we can inform the frontend that no base report has been found.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports