Code Quality MR widget: Base pipeline artifact not found error should depend on backend status
Context
We are in the process of moving the code quality report comparison logic to the backend, this is behind the feature flag :codequality_backend_comparison
for now.
There should be an error message that shows when there is no code quality artifact available for the base pipeline:
(i.e. the artifact from the pipeline of the master
commit that the MR's branch is based on is not available, because the code quality job didn't run on master
, or because the artifact has expired, etc.)
Proposal
We should make this error message depend on the new backend comparison status
and/or status_reason
, because right now it depends on the presence of the path used to download the artifact for comparison, and we intend to remove that path when we remove the :codequality_backend_comparison
feature flag because we won't need to download the artifact any more.
Options:
- Display the exact same popover when the report status is
not_found
- Take the error message from the popover, but display it directly in the widget when the report status is
not_found
(which also addresses #293716) - Remove frontend popover code altogether, get the backend to return the message as a
status_reason
(similarly to what we do for"This merge request does not have codequality reports"
, which would appear in the body of the widget (which also addresses #293716)