Skip to content
Snippets Groups Projects

Add Lefthook to the Gemfile and improve documentation

Merged Rémy Coutable requested to merge add-lefthook-to-gemfile into master
All threads resolved!

What does this MR do?

I think Lefthook has proven to work well, and I don't see a good reason not to add it to the development dependencies (similarly to how we install it in the GDK: gitlab-development-kit!1500 (diffs)).

I've also improved the documentation by describing the current configuration.

Edited by Rémy Coutable

Merge request reports

Merged results pipeline #245305540 passed

Merged results pipeline passed for 0230eb2e

Test coverage 70.26% (11.89%) from 3 jobs

Merged by Heinrich Lee YuHeinrich Lee Yu 4 years ago (Jan 22, 2021 7:24am UTC)

Loading

Pipeline #245318670 passed

Pipeline passed for 5e633180 on master

Test coverage 58.36% (11.89%) from 3 jobs
5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rémy Coutable
  • Rémy Coutable added 1 commit

    added 1 commit

    • cda2d0fc - Add Lefthook to the Gemfile and improve documentation

    Compare with previous version

  • Rémy Coutable added 1 commit

    added 1 commit

    • b54cecd4 - Add Lefthook to the Gemfile and improve documentation

    Compare with previous version

  • Rémy Coutable assigned to @ashmckenzie and unassigned @rymai

    assigned to @ashmckenzie and unassigned @rymai

  • Rémy Coutable mentioned in merge request !52114 (merged)

    mentioned in merge request !52114 (merged)

  • Rémy Coutable assigned to @engwan and unassigned @ashmckenzie

    assigned to @engwan and unassigned @ashmckenzie

  • Heinrich Lee Yu
  • Heinrich Lee Yu
  • Heinrich Lee Yu
  • Heinrich Lee Yu approved this merge request

    approved this merge request

  • Heinrich Lee Yu assigned to @eread and unassigned @engwan

    assigned to @eread and unassigned @engwan

  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read added 1 commit

    added 1 commit

    • ee4b0820 - Apply 5 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read resolved all threads

    resolved all threads

  • Evan Read added 1 commit

    added 1 commit

    • 03ca106d - Apply 3 suggestion(s) to 1 file(s)

    Compare with previous version

  • Evan Read
  • Evan Read approved this merge request

    approved this merge request

  • Evan Read resolved all threads

    resolved all threads

  • Evan Read assigned to @engwan and unassigned @eread

    assigned to @engwan and unassigned @eread

  • Heinrich Lee Yu enabled an automatic merge when the pipeline for 0230eb2e succeeds

    enabled an automatic merge when the pipeline for 0230eb2e succeeds

  • Thanks @rymai @eread, MWPS set :thumbsup:

  • Heinrich Lee Yu mentioned in commit 5e633180

    mentioned in commit 5e633180

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • added typemaintenance label and removed tooling (archive) label

  • Please register or sign in to reply
    Loading