Add Lefthook to the Gemfile and improve documentation
What does this MR do?
I think Lefthook has proven to work well, and I don't see a good reason not to add it to the development dependencies (similarly to how we install it in the GDK: gitlab-development-kit!1500 (diffs)).
I've also improved the documentation by describing the current configuration.
Merge request reports
Activity
mentioned in issue gitlab-development-kit#1149 (closed)
changed milestone to %13.9
added backend documentation labels
added tooling (archive) label
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/development/contributing/style_guides.md
doc/development/documentation/testing.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Małgorzata Ksionek ( @mksionek
) (UTC+1, same timezone as@rymai
)Heinrich Lee Yu ( @engwan
) (UTC+8, 7 hours ahead of@rymai
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Evan Read
- Resolved by Heinrich Lee Yu
added 1 commit
- cda2d0fc - Add Lefthook to the Gemfile and improve documentation
added 1 commit
- b54cecd4 - Add Lefthook to the Gemfile and improve documentation
- Resolved by Heinrich Lee Yu
@ashmckenzie Could you please review? Thanks!
assigned to @ashmckenzie and unassigned @rymai
mentioned in merge request !52114 (merged)
assigned to @engwan and unassigned @ashmckenzie
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
- Resolved by Evan Read
added Technical Writing docsimprovement twfinished labels
enabled an automatic merge when the pipeline for 0230eb2e succeeds
mentioned in commit 5e633180
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added typemaintenance label and removed tooling (archive) label