Skip to content

Draft: Boards - Turn on graphql_board_lists feature flag for project boards [AS-IF-FOSS]

Florie Guibert requested to merge feature/turn-on-graphql-project-boards into master

What does this MR do?

THIS IS A DRAFT - DO NOT MERGE

Turn on graphql_board_lists feature flag for project boards. (To see what breaks)

Follow-up required

Notes

Was mostly adding some of the existing sidebar selectors (I preferred adding 1 class vs changing many tests)

"javascript error: Cannot destructure property 'children' of 'el' as it is undefined."

  • rspec ./ee/spec/features/boards/swimlanes/epics_swimlanes_drag_issue_spec.rb:71 # epics swimlanes drag and drop issue from unassigned issues lane to epic

these two are both "element not interactable: element has zero size"

  • rspec ./spec/features/boards/sidebar_spec.rb:428 # Issue Boards subscription changes issue subscription
  • rspec ./spec/features/boards/sidebar_spec.rb:440 # Issue Boards subscription has checked subscription toggle when already subscribed

Resolved by !51423 (3fa6b21a):

  • rspec ./ee/spec/features/boards/boards_spec.rb:133 # issue boards total weight shows total weight for backlog
  • rspec ./ee/spec/features/boards/boards_spec.rb:138 # issue boards total weight updates weight when moving to list
  • rspec ./ee/spec/features/boards/boards_spec.rb:159 # issue boards total weight unlicensed hides weight

An actual bug caused the spec failure (in addition to mismatching selectors) !51423 (c2d4f95d)

  • rspec ./ee/spec/features/boards/sidebar_spec.rb:187 # Issue Boards epic when the issue is associated with an epic displays name of epic and links to it

This spec will require an additional backend work (See !51423 (comment 515733255))

  • rspec './ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb[1:3:1:2:3:2:1:1]' # Filter issues by iteration project board behaves like filters by iteration when iterations are available when filtering by negated iteration with current iteration behaves like filters issues by negated iteration filters by negated iteration

Quarantined Spec

The epic component in the new sidebar has a known issue #299159 (closed). The following spec needs to be quarantined for now.

  • rspec ./ee/spec/features/boards/sidebar_spec.rb:194 # Issue Boards epic when the issue is associated with an epic updates the epic associated with the issue

Specs to remove

!51423 (comment 515844321)

  • rspec ./ee/spec/features/boards/boards_spec.rb:176 # issue boards locked milestone does not have remove button[ ]
Edited by euko

Merge request reports