Filter by reviewer in MergeRequest List API
What does this MR do?
This MR adds Reviewer
filtering support for MergeRequest List API.
Related to #291038 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.7
added api backend devopscreate groupcode review typefeature labels
1 Warning a8195fa4: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 49341 "Filter by reviewer in MergeRequest List API"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 49341 "Filter by reviewer in MergeRequest List API"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/api/merge_requests.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend John Hope ( @johnhope
) (UTC+0, 10.5 hours behind@dskim_gitlab
)Kerri Miller ( @kerrizor
) (UTC-8, 18.5 hours behind@dskim_gitlab
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #291038 (closed)
added sectiondev label
added 1 commit
- 091af23f - Add reviewer filtering support for MergeRequest List API
added documentation label
added 869 commits
-
091af23f...5559a68e - 868 commits from branch
master
- ad227c2e - Add reviewer filtering support for MergeRequest List API
-
091af23f...5559a68e - 868 commits from branch
added 1 commit
- 8d4b1254 - Add reviewer filtering support for MergeRequest List API
added 1 commit
- 98220dbe - Add reviewer filtering support for MergeRequest List API
added 1 commit
- e841d078 - Add reviewer filtering support for MergeRequest List API
- Resolved by Dmytro Zaporozhets (DZ)
@mdelaossa As I mentioned in the issue, would you be able to review this as a backend reviewer please?
@marcia Can you please have a look at the documentation?
assigned to @marcia and @mdelaossa
unassigned @marcia and @mdelaossa
- Resolved by Marcia Ramos
- Resolved by Dmytro Zaporozhets (DZ)