Update group member search
What does this MR do?
A search feature is being added to the group billable members page (issue here). This backend MR updates the group/:id/billable_members
endpoint, which is currently used to retrieve the entire list of billable group members.
The search params defined in this MR are based on the proposed design.
No changelog provided as we're hiding that new feature behind the api_billable_member_list
feature flag (see related issue)
Finally a frontend MR will follow this one here.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- Changelog entry
- Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #262875 (closed)
Merge request reports
Activity
changed milestone to %13.7
added backend label
added 129 commits
-
5f817db5...f3c9c0e1 - 128 commits from branch
master
- 5f217a68 - Updated group memeber search
-
5f817db5...f3c9c0e1 - 128 commits from branch
added 13 commits
-
5f217a68...fb69f4a9 - 12 commits from branch
master
- 36c39dc4 - Updated group member search
-
5f217a68...fb69f4a9 - 12 commits from branch
- Resolved by Thong Kuah
assigned to @acroitor
added workflowin review label and removed workflowin dev label
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
unassigned @acroitor
added 40 commits
-
94a253a1...37f11976 - 38 commits from branch
master
- 58f61e9a - Updated group member search
- 59ab2e40 - Applied comments from code reviewer
-
94a253a1...37f11976 - 38 commits from branch
added 140 commits
-
59ab2e40...a38eaf06 - 138 commits from branch
master
- 91a1524f - Updated group member search
- 53e31aea - Applied comments from code reviewer
-
59ab2e40...a38eaf06 - 138 commits from branch
- Resolved by Alexandru Croitor
assigned to @acroitor
added 172 commits
-
7f44bb07...2abdaa63 - 170 commits from branch
master
- 12cfadcc - Updated group member search
- 8a119363 - Applied comments from code reviewer
-
7f44bb07...2abdaa63 - 170 commits from branch
added documentation label
unassigned @acroitor
- Resolved by Alexandru Croitor
added 52 commits
-
9c9aef8f...55b92a6b - 50 commits from branch
master
- e71cabf0 - Updated group member search
- d6a09b82 - Applied comments from code reviewer
-
9c9aef8f...55b92a6b - 50 commits from branch
- Resolved by Thong Kuah
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
added 32 commits
-
50d91b38...1ebf531a - 30 commits from branch
master
- c5910791 - Updated group member search
- 3b418cac - Applied comments from code reviewer
-
50d91b38...1ebf531a - 30 commits from branch
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
- Resolved by Alexandru Croitor
unassigned @acroitor