Utilize approver suggestion partial
What does this MR do?
This MR moves the suggested approvers into a partial, so it is easily reused in this MR > !47475 (merged)
| MR | Changes |
|---|---|
| Part 1: |
Create suggested approvers as a partial so it can be reused |
| Part 2: !47475 (merged) | Collapse approval rules and move it under reviewers |
| Part 3: Issue: #284212 (closed) | Move suggested approver into Vue app |
Testing Case
Changes in this MR will have no effect on existing behaviour. But here are some screenshots to see what approval rules is about
| Free | License |
|---|---|
 |
 |
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Samantha Ming