Skip to content

Move Suggested Approvers into the Vue app

The following discussion from !47475 (merged) should be addressed:

Scope of this issue

The idea is simply to make sure the messages re: Approval Rules show up within the expanded content, not outside.

More information

In order for the Code Owners tip to be inside the collapse, we need to move it inside our vue app.

  • ee/app/assets/javascripts/approvals/components/mr_edit/app.vue

There are 2 states of content that are displayed in this area.

Displays Approvers Display Tips
image This has been removed already: #284825 (closed) image

After this MR > !47475 (merged) is merged, there will be 2 files where updates need to be made:

  • app/views/shared/issuable/form/_metadata_issuable_reviewer.html.haml
  • ee/app/views/shared/issuable/_approvals.html.haml

Suggestion

The static content of the displaying tip can be easily moved. However the dynamic content of the suggested approvers will be a bit more work. One suggestion is to pass it into Vue via the data attribute. Suggested approvers have been removed: #284825 (closed)

image

Edited by André Luís