Collapse approval rules and move it under reviewer

changed milestone to %13.6

added Category:Code Review Workflow Category:Source Code Management Deliverable GitLab Core design-weight1 devopscreate direction frontend frontend-weight1 groupsource code quad-planningcomplete-action sectiondev typefeature labels

changed the description

assigned to @pedroms

marked this merge request as draft

3 Messages

This merge request adds or changes files that require a review from the Database team.

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, run the following:

bin/changelog -m 47475 "Collapse approval rules and move it under reviewer"

If you want to create a changelog entry for GitLab EE, run the following instead:

bin/changelog --ee -m 47475 "Collapse approval rules and move it under reviewer"

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

This merge request adds or changes files that require a review from the CI/CD Templates maintainers.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
backend	Kassio Borges (`@kassio`) (UTC+0, 8 hours ahead of `@sming-gitlab`)	Stan Hu (`@stanhu`) (UTC-8, same timezone as `@sming-gitlab`)
database	Doug Stull (`@dstull`) (UTC-5, 3 hours ahead of `@sming-gitlab`)	Patrick Bair (`@pbair`) (UTC-5, 3 hours ahead of `@sming-gitlab`)
frontend	Zack Cuddy (`@zcuddy`) (UTC-6, 2 hours ahead of `@sming-gitlab`)	Olena HK. (`@ohoral`) (UTC+2, 10 hours ahead of `@sming-gitlab`)
test Quality for `spec/features/*`	Mark Lapierre (`@mlapierre`) (UTC+11, 19 hours ahead of `@sming-gitlab`)	Maintainer review is optional for test Quality for `spec/features/*`

This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
Prepare your MR for a CI/CD Template review according to the template development guide.
Assign and @ mention the CI/CD Template reviewer suggested by Reviewer Roulette.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@pedroms this is the direction I'm moving towards, do you mind checking if this aligns with what you have in mind? (Code is still WIP, but I have a video recording in the description that you can check out )

@jeldergl Question: Do you know what the expected hover state is for an accordion? In this MR we're implementing the first version of it in Vue.

assigned to @jeldergl and unassigned @pedroms

changed the description

added 1 commit

be6592f9 - Hide collapse behind feature flag

MR	Changes
Part 1: !47976 (merged)	Create suggested approvers as a partial so it can be reused
Part 2: current	FE implementation of collapsing Approval Rules under Reviewers

FF	Is Collapsed?
`merge_request_reviewers` True `mr_collapsed_approval_rules` = True	Yes
`merge_request_reviewers` False `mr_collapsed_approval_rules` = False	No
`merge_request_reviewers` True `mr_collapsed_approval_rules` = False	No
`merge_request_reviewers` False `mr_collapsed_approval_rules` = True	No

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.03 MB	3.03 MB	-	0.0 %
mainChunk	1.88 MB	1.88 MB	-	0.0 %

Collapse approval rules and move it under reviewer

What does this MR do?

Testing Case

Edit MR

Create MR

Not collapsed

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Merge request reports

Activity

Reviewer roulette

Bundle size analysis [beta]

Special assets