Skip to content
Snippets Groups Projects

Changes limit for lsif artifacts to 100MB

Merged Igor Drozdov requested to merge id-change-default-for-ci-max-artifact-size-lsif into master

What does this MR do?

Related issue: #249561 (closed)

After the recent fix of the in-memory processing, the memory usage reduced significantly for a large file, maybe we can try increasing the limit without waiting for gitlab-workhorse#270 (moved).

Up:

== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: migrating
-- change_column_default(:plan_limits, :ci_max_artifact_size_lsif, 100)
   -> 0.0133s
-- execute("UPDATE plan_limits SET ci_max_artifact_size_lsif = 100 WHERE ci_max_artifact_size_lsif = 20")
   -> 0.0063s
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: migrated (0.0316s)

Down:

== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: reverting
-- change_column_default(:plan_limits, :ci_max_artifact_size_lsif, 20)
   -> 0.0072s
-- execute("UPDATE plan_limits SET ci_max_artifact_size_lsif = 20 WHERE ci_max_artifact_size_lsif = 100")
   -> 0.0007s
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: reverted (0.0134s)
Edited by Igor Drozdov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcia Ramos
  • Marcia Ramos
  • As @marcel.amirault reviewed the linked MR and these docs, I'll pass this review over to him. Marcel, could you please take a look? Tnx!

  • Marcia Ramos assigned to @marcel.amirault and unassigned @marcia

    assigned to @marcel.amirault and unassigned @marcia

  • Tiger Watson assigned to @sabrams and unassigned @tigerwnz

    assigned to @sabrams and unassigned @tigerwnz

  • assigned to @marcia and unassigned @marcel.amirault

  • Igor Drozdov added 1 commit

    added 1 commit

    • 7f43dbb3 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Igor Drozdov added 1 commit

    added 1 commit

    • 07d21603 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Igor Drozdov added 439 commits

    added 439 commits

    Compare with previous version

  • Steve Abrams
  • Steve Abrams
  • Thanks @igor.drozdov, the database updates LGTM, I left two minor non-blocking comments, but this is ready for maintainer review @tigerwnz.

  • Steve Abrams assigned to @tigerwnz and unassigned @sabrams

    assigned to @tigerwnz and unassigned @sabrams

  • added databasereviewed label and removed databasereview pending label

  • Steve Abrams approved this merge request

    approved this merge request

  • Igor Drozdov changed the description

    changed the description

  • Igor Drozdov added 1 commit

    added 1 commit

    • 12f01f70 - Changes limit for lsif artifacts to 100MB

    Compare with previous version

  • Tiger Watson approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Tiger Watson resolved all threads

    resolved all threads

  • Tiger Watson enabled an automatic merge when the pipeline for 8ae7636c succeeds

    enabled an automatic merge when the pipeline for 8ae7636c succeeds

  • merged

  • Tiger Watson mentioned in commit 5ee6edc1

    mentioned in commit 5ee6edc1

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Thao Yeager mentioned in issue #283981

    mentioned in issue #283981

  • added groupcode review label and removed groupsource code label

  • Kai Armstrong mentioned in issue #412981

    mentioned in issue #412981

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading