Changes limit for lsif artifacts to 100MB
What does this MR do?
Related issue: #249561 (closed)
After the recent fix of the in-memory processing, the memory usage reduced significantly for a large file, maybe we can try increasing the limit without waiting for gitlab-workhorse#270 (moved).
Up:
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: migrating
-- change_column_default(:plan_limits, :ci_max_artifact_size_lsif, 100)
-> 0.0133s
-- execute("UPDATE plan_limits SET ci_max_artifact_size_lsif = 100 WHERE ci_max_artifact_size_lsif = 20")
-> 0.0063s
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: migrated (0.0316s)
Down:
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: reverting
-- change_column_default(:plan_limits, :ci_max_artifact_size_lsif, 20)
-> 0.0072s
-- execute("UPDATE plan_limits SET ci_max_artifact_size_lsif = 20 WHERE ci_max_artifact_size_lsif = 100")
-> 0.0007s
== 20201105135051 ChangeDefaultValueOfCiMaxArtifactSizeLsifOfPlanLimitsFrom20To100: reverted (0.0134s)
Merge request reports
Activity
changed milestone to %13.6
added Category:Code Review Workflow backend devopscreate groupsource code labels
added databasereview pending label
added database documentation labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/administration/instance_limits.md
doc/user/project/code_intelligence.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer database Steve Abrams ( @sabrams
) (UTC-7, 10 hours behind@igor.drozdov
)Patrick Bair ( @pbair
) (UTC-5, 8 hours behind@igor.drozdov
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Tiger Watson
@tigerwnz since you reviewed !37018 (merged) and this merge request is mostly inspired by it, could you please review this on from database perspective?
@marcia could you please review the doc changes?
mentioned in merge request !46766 (closed)
- Resolved by Tiger Watson
- Resolved by Igor Drozdov
- Resolved by Igor Drozdov
As @marcel.amirault reviewed the linked MR and these docs, I'll pass this review over to him. Marcel, could you please take a look? Tnx!
assigned to @marcel.amirault and unassigned @marcia
added Technical Writing docsfeature twdoing labels
- Resolved by Tiger Watson
@igor.drozdov maybe we should add this to https://docs.gitlab.com/ee/user/gitlab_com/#gitlabcom-settings too, WDYT?
Setting label(s) Category:Source Code Management sectiondev based on groupsource code.
added Category:Source Code Management sectiondev labels
assigned to @marcia and unassigned @marcel.amirault
added 439 commits
-
07d21603...db863982 - 438 commits from branch
master
- 36aa24e1 - Changes limit for lsif artifacts to 100MB
-
07d21603...db863982 - 438 commits from branch
- Resolved by Igor Drozdov
- Resolved by Tiger Watson
Thanks @igor.drozdov, the database updates LGTM, I left two minor non-blocking comments, but this is ready for maintainer review @tigerwnz.
added databasereviewed label and removed databasereview pending label
added databaseapproved label and removed databasereviewed label
enabled an automatic merge when the pipeline for 8ae7636c succeeds
mentioned in commit 5ee6edc1
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in issue #283981
added groupcode review label and removed groupsource code label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label
mentioned in issue #412981