Skip to content

Enable secret detection in MR Widget

Dheeraj Joshi requested to merge djadmin-secret-detection into master

Related #244836 (closed)

What does this MR do?

This should enable secret detection reports in MR Widget by

  • Adding secret_detection to enabled reports

  • Setting correct help path, comparision path and

  • Replacing secret_scanning with secret_detection wherever necessary for frontend to send correct request params

    (This is due to the fact that the frontend uses secret_scanning while backend expects this report category as secret_detection)

Follow ups

  1. frontend - #247498 (closed), #247500 (closed)
  2. backend - #247532 (closed)

Screenshots

What Screenshot
When no vulnerabilities are found image
With vulnerabily image
Tooltip image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports