Skip to content
Snippets Groups Projects

Add help text for type select

Merged David O'Regan requested to merge 230857-incident-type-selector-help into master

What does this MR do?

A small MVC to add a section of help text and help link to incident management for the type selector.

Screenshots

Issue Incidents
Screenshot_2020-09-04_10-55-06 Screenshot_2020-09-07_at_15.11.47

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Contributes to #230857 (closed)

Edited by David O'Regan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David O'Regan resolved all threads

    resolved all threads

  • David O'Regan added 1 commit

    added 1 commit

    • e05a6fb2 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added frontend test + 1 deleted label

  • 1 Warning
    :warning: ff4e5641: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    frontend Dennis Tang (@dennis) (UTC-7, 8 hours behind @oregand) Phil Hughes (@iamphill) (UTC+1, same timezone as @oregand)
    test Quality for spec/features/* Hordur Freyr Yngvason (@hfyngvason) (UTC-4, 5 hours behind @oregand) Maintainer review is optional for test Quality for spec/features/*

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 88c77f7c and 071f9f5b

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.51 MB 3.51 MB - 0.0 %
    mainChunk 2.64 MB 2.64 MB - 0.0 %

    Note: We do not have exact data for 88c77f7c. So we have used data from: 512ffad9.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • David O'Regan added 1 commit

    added 1 commit

    • fc5a1f7a - Add translations and linting fix

    Compare with previous version

  • David O'Regan added 441 commits

    added 441 commits

    Compare with previous version

  • David O'Regan changed the description

    changed the description

  • David O'Regan added 256 commits

    added 256 commits

    Compare with previous version

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Amelia Bauerly approved this merge request

    approved this merge request

  • David O'Regan added 1 commit

    added 1 commit

    Compare with previous version

  • David O'Regan added 142 commits

    added 142 commits

    Compare with previous version

  • David O'Regan added 1 commit

    added 1 commit

    Compare with previous version

  • Tristan Read approved this merge request

    approved this merge request

  • assigned to @ohoral

  • David O'Regan added 1 commit

    added 1 commit

    • 071f9f5b - Remove designs from incidents

    Compare with previous version

  • Olena Horal-Koretska approved this merge request

    approved this merge request

  • assigned to @svistas

  • David O'Regan added 1 commit

    added 1 commit

    Compare with previous version

  • Sofia Vistas
  • Sofia Vistas assigned to @ohoral and unassigned @svistas

    assigned to @ohoral and unassigned @svistas

  • Sofia Vistas approved this merge request

    approved this merge request

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Olena Horal-Koretska enabled an automatic merge when the pipeline for 35cab8df succeeds

    enabled an automatic merge when the pipeline for 35cab8df succeeds

  • mentioned in commit 0e1d43f9

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading