Add help text for type select
What does this MR do?
A small MVC to add a section of help text and help link to incident management for the type selector.
Screenshots
Issue | Incidents |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Contributes to #230857 (closed)
Merge request reports
Activity
changed milestone to %13.4
assigned to @ameliabauerly and @tristan.read
- Resolved by Olena Horal-Koretska
added 1 commit
- 528d2746 - Update 230857-incident-type-selector-help.yml
- Resolved by David O'Regan
1 Warning ff4e5641: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Dennis Tang ( @dennis
) (UTC-7, 8 hours behind@oregand
)Phil Hughes ( @iamphill
) (UTC+1, same timezone as@oregand
)test Quality for spec/features/*
Hordur Freyr Yngvason ( @hfyngvason
) (UTC-4, 5 hours behind@oregand
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 88c77f7c and 071f9f5b
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - 0.0 % mainChunk 2.64 MB 2.64 MB - 0.0 %
Note: We do not have exact data for 88c77f7c. So we have used data from: 512ffad9.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 441 commits
Toggle commit listunassigned @ameliabauerly
unassigned @tristan.read
assigned to @ameliabauerly and @tristan.read
added 256 commits
-
48c0ed52...b2806985 - 250 commits from branch
master
- 2853c9e8 - Add help text for type select
- d7af060e - Add help text for type select
- d4d5092d - Update 230857-incident-type-selector-help.yml
- 5eaab0e4 - Apply 1 suggestion(s) to 1 file(s)
- 66d46308 - Add translations and linting fix
- e444876c - Address merge feedback
Toggle commit list-
48c0ed52...b2806985 - 250 commits from branch
unassigned @ameliabauerly
- Resolved by Olena Horal-Koretska
- Resolved by Olena Horal-Koretska
- Resolved by Olena Horal-Koretska
@oregand I've added a couple more comments, sorry for not noticing these in my first pass. I'll keep an eye on the MR so that once you've made the changes I can get it back to you as soon as possible
unassigned @tristan.read
added 142 commits
-
41d7dde2...438aade5 - 134 commits from branch
master
- 5009f39b - Add help text for type select
- fb8b2991 - Add help text for type select
- ff4e5641 - Update 230857-incident-type-selector-help.yml
- c5e17542 - Apply 1 suggestion(s) to 1 file(s)
- 48b8db00 - Add translations and linting fix
- 6d7f1bb5 - Address merge feedback
- 5303ed59 - Address merge feedback
- 74f66c6d - Update from merge feedback
Toggle commit list-
41d7dde2...438aade5 - 134 commits from branch
assigned to @tristan.read
- Resolved by Olena Horal-Koretska
@oregand Thanks for the changes, it looks great. Approving, back to you
Edited by Tristan Read
unassigned @tristan.read
assigned to @ohoral
unassigned @ohoral
assigned to @svistas
- Resolved by Olena Horal-Koretska
enabled an automatic merge when the pipeline for 35cab8df succeeds
mentioned in commit 0e1d43f9
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.