Skip to content
Snippets Groups Projects

Resolve "Add Type selector to new Issue creation form"

Merged David O'Regan requested to merge 230857-incident-type-selector into master

What does this MR do?

This merge is a tiny MVC for #230857 (closed) where we add a new dropdown to the Issue creation for called: Type. This drop-down defaults to the type issue but allows for type incident to be selected. This merge also hides certain dropdowns for type incident i.e. weight, epic && milestone.

  • Issue => Shows all dropdowns
  • Incident => Hides epic, weight && milestone dropdowns to reflect sidebar.

Operations > Incidents > Create new incident: This button pre-selects the Incident type in the dropdown, all other buttons pre-select issue.

Screenshots

Issue Incident
Screenshot_2020-09-01_15-07-00 Screenshot_2020-09-01_15-05-36

Screenshot_2020-09-01_15-06-03 Screenshot_2020-09-01_15-15-04 Screenshot_2020-09-01_15-16-24

Supporting MRs

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #230857 (closed)

Edited by David O'Regan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David O'Regan
  • David O'Regan
    • Resolved by Natalia Tepluhina

      @oregand - it's looking great! A few thoughts here:

      • I was curious why you went with the header variant of the dropdown rather than the standard dropdown - I suppose it's because that's what's used on the other dropdowns in the form? It feels a little unnecessary, having the header and the additional close button here but, I suppose it makes sense to keep all the dropdowns consistent on this page. Is that what you were thinking?

      • I'm wondering if we should follow this same flow with the "create issue" flow from alerts?

      create_incident_flow

      So, clicking "create incidents" button would also open up the "new issue" form with the incident issue type selected?

      • I noticed our manually created incidents aren't automatically adding the "incident" label. This means that, if I go to the issue list, there's not really any way of telling which items are incidents and which are not:

      issue_list

      I wonder if we should create a follow-up to improve this experience a bit? It seems like, for instance, we should add in an "issue type" filter on the issue list page so that people can easily find all of their incidents even if they forget to add the label. WDYT?

      Edited by Amelia Bauerly
  • David O'Regan added 164 commits

    added 164 commits

    Compare with previous version

  • @oregand triggered package-and-qa job to run the feature specs :thumbsup:

  • Sofia Vistas approved this merge request

    approved this merge request

  • David O'Regan assigned to @euko and unassigned @jackie_fraser

    assigned to @euko and unassigned @jackie_fraser

  • unassigned @euko

  • assigned to @tomquirk

  • David O'Regan added 423 commits

    added 423 commits

    Compare with previous version

  • David O'Regan changed the description

    changed the description

  • Amelia Bauerly approved this merge request

    approved this merge request

  • Tom Quirk approved this merge request

    approved this merge request

  • unassigned @tomquirk

  • @oregand thank you, MR LGTM! :thumbsup_tone1:

  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • mentioned in commit 54e30da3

  • added workflowstaging label and removed workflowin review label

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #25840 (closed)

  • mentioned in issue #244938 (closed)

  • mentioned in issue #244995 (closed)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading