Resolve "Add Type selector to new Issue creation form"
What does this MR do?
This merge is a tiny MVC for #230857 (closed) where we add a new dropdown to the Issue creation for called: Type. This drop-down defaults to the type issue
but allows for type incident
to be selected. This merge also hides certain dropdowns for type incident i.e. weight, epic && milestone.
- Issue => Shows all dropdowns
- Incident => Hides epic, weight && milestone dropdowns to reflect sidebar.
Operations > Incidents > Create new incident
: This button pre-selects the Incident type in the dropdown, all other buttons pre-select issue.
Screenshots
Issue | Incident |
---|---|
![]() |
![]() |
Supporting MRs
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #230857 (closed)
Merge request reports
Activity
changed milestone to %13.4
1 Warning This MR has a Changelog file outside ee/
, but code changes inee/
. Consider moving the Changelog file intoee/
.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Justin Boyson ( @jboyson
) (UTC-5, 6 hours behind@oregand
)Natalia Tepluhina ( @ntepluhina
) (UTC+3, 2 hours ahead of@oregand
)test Quality for spec/features/*
Giorgenes Gelatti ( @ggelatti
) (UTC+10, 9 hours ahead of@oregand
)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5e95de31 and cbd24fa0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.68 MB 2.68 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 99 commits
-
ac1cc5e1...1e0ff62a - 81 commits from branch
master
- d77b6b9f - feat: Highlight currently focused/viewed file
- c23b41ab - chore: update based on MR feedback
- b3929db3 - chore: update based on MR suggestions
- a8928781 - chore: apply patch for tree list spec
- f423ab99 - fix(diff): account for different string matchs for field ID from header
- 73841761 - chore: linting
- 9aad262e - Update per feedback
- 807f88ab - Add feature flag
- 94520053 - Apply merge feedback
- ded2cfcf - Apply merge feedback
- 8d747b98 - Apply merge feedback
- 6323250f - Apply merge feedback
- 90a71a4d - Apply merge feedback
- 69b84c58 - Add base type selector
- 686b1889 - Update select type
- dd8e362f - Update select type
- ea052f9c - Update dropdown styles
- c68e6df7 - Update dropdown styles
Toggle commit list-
ac1cc5e1...1e0ff62a - 81 commits from branch
added workflowin review label and removed workflowready for development label
added UX label
Could you do the frontend review for this change please?
Can you please give this a UX review please?
Would I be correct that this drop-down shouldn't show when Incidents are not enabled? Or do we still show it but disable the Incident option?
Also, when we select Incident should we change the button text from: "Submit issue" to "Submit incident"?
Could you review this from a QA perspective?
Edited by David O'Reganassigned to @jackie_fraser, @ameliabauerly, and @svistas
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
- Resolved by Natalia Tepluhina
@oregand - it's looking great! A few thoughts here:
-
I was curious why you went with the header variant of the dropdown rather than the standard dropdown - I suppose it's because that's what's used on the other dropdowns in the form? It feels a little unnecessary, having the header and the additional close button here but, I suppose it makes sense to keep all the dropdowns consistent on this page. Is that what you were thinking?
-
I'm wondering if we should follow this same flow with the "create issue" flow from alerts?
So, clicking "create incidents" button would also open up the "new issue" form with the
incident
issue type selected?- I noticed our manually created incidents aren't automatically adding the "incident" label. This means that, if I go to the issue list, there's not really any way of telling which items are incidents and which are not:
I wonder if we should create a follow-up to improve this experience a bit? It seems like, for instance, we should add in an "issue type" filter on the issue list page so that people can easily find all of their incidents even if they forget to add the label. WDYT?
Edited by Amelia Bauerly -
unassigned @ameliabauerly
added 164 commits
-
8ed9f7cc...7184f293 - 163 commits from branch
master
- d4ba5f8d - Add type selector for issues
-
8ed9f7cc...7184f293 - 163 commits from branch
added sectionops label
assigned to @euko and unassigned @jackie_fraser
unassigned @euko
assigned to @tomquirk
- Resolved by Natalia Tepluhina
It appears @jackie_fraser is at capacity, would you mind reviewing this merge for me on the frontend side please?
unassigned @svistas
assigned to @ameliabauerly
added 423 commits
-
d4ba5f8d...1a9d624a - 422 commits from branch
master
- cbd24fa0 - Add type selector for issues
-
d4ba5f8d...1a9d624a - 422 commits from branch
unassigned @ameliabauerly
assigned to @ameliabauerly
unassigned @ameliabauerly
unassigned @tomquirk
assigned to @ntepluhina
@oregand thank you, MR LGTM!
mentioned in commit 54e30da3
added workflowstaging label and removed workflowin review label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #25840 (closed)
mentioned in issue #244938 (closed)
mentioned in issue #244995 (closed)