Skip to content

Part 2: Add reviewers to side widget (Vue Components)

Samantha Ming requested to merge 237921-vue-side-widget-add-reviewers into master

Issue: #237921 (closed)

What does this MR do?

This MR adds the Vue components, so there is the reviewers selection in the sidebar.

MR Changes
!40488 (merged) Add reviewers to MR form (BE)
!40330 (merged) Add reviewers to MR form (FE)
!40424 (merged) Part 1: Add reviewers to Sidebar -- Setup (HAML + JS)
👉 this MR Part 2: Add reviewers to Sidebar -- Vue related (mount, components, spec)

Note

This is the first iteration. For simplicity, we are just copying the implementation of the "Assignees" dropdown. As this will be overhauled and replaced in the next iteration > #233736 (closed)

Testing Case

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(:merge_request_reviewers)
  1. Go to a Merge Request
  2. Make sure the sidebar is non-collapsed
  • There is a Reviewer selection
  1. Select a reviewer
  • The saved reviewer(s) will appear
Reviewer Reviewers
image image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #237921 (closed)

Closes #237921 (closed)

Edited by Samantha Ming

Merge request reports