Part 1: Add reviewers to side widget (Setup HAML + JS)
Issue: #237921 (closed)
What does this MR do?
This is part 1 of adding the feature of having reviewers selection in the MR widget. I'm breaking this into 2 separate MR to keep the MR small and easier to review. In this MR, it will just contain the setup pieces (HAML + JS). The actual vue components and mount will be in part 2.
| MR | Changes |
|---|---|
| !40488 (merged) | Add reviewers to MR form (BE) |
| !40330 (merged) | Add reviewers to MR form (FE) |
| Part 1: Add reviewers to Sidebar -- Setup (HAML + JS) | |
| !40926 (merged) | Part 2: Add reviewers to Sidebar -- Vue related (mount, components, spec) |
Screenshots
NOTE This MR will not have any UI change. But I'm including a copy of Part 2's screenshot that might provide context what Part 1 is helping achieve
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #237921 (closed)
Edited by Samantha Ming