Skip to content

Add reviewers to MR form

Samantha Ming requested to merge 216054-add-reviewers-to-mr-form into master

Issue: #216054 (closed)

What does this MR do?

MR Changes
!40488 (merged) Add reviewers to MR form (BE)
👉 this MR Add reviewers to MR form (FE)
!40424 (merged) Part 1: Add reviewers to MR widget -- Setup (HAML + JS)
!40926 (merged) Part 2: Add reviewers to MR widget -- Vue related (mount, components, spec)

Testing Case

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(:merge_request_reviewers)
  1. Go to a Merge Request
  2. Click the Edit button
  • There is a reviewers dropdown
  1. Select a reviewer and click "Save". This will redirect you to the MR page
  2. Click the "Edit" button again to check the reviewers are saved.
  • The saved reviewer(s) will appear
Reviewer Reviewers
image image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #216054 (closed)

Edited by Samantha Ming

Merge request reports