Updated SSE front matter language support
What does this MR do?
It adds support for TOML and JSON front matter language types to the static site editor.
- The main goal of this MR is to facilitate a downstream MR (MR3) where I anticipate adding an
engine
that hasparse
andstringify
functions so each definition can manage the actual parsing of the respective front matter language type to a JavaScript object for further downstream use of having a dedicated UI for front matter editing - Secondarily, SSE use outside the handbook with
.md
files containing TOML or JSON front matter will now properly be parsed out of WYSIWYG mode
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #241000 (closed)
Merge request reports
Activity
changed milestone to %13.4
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Miranda Fluharty ( @mfluharty
) (UTC+1)Vitaly Slobodin ( @vitallium
) (UTC+3)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- b99d6d2f - Add toml and json front matter support to SSE
marked the checklist item Changelog entry as completed
- Resolved by Derek Knox
@ealcantara Please review when time permits.
FYI, you can view note-to-self style comments in the related issue about why I backed out of using
gray-matter
. I went back and forth on this mentally a few times.Edited by Derek Knox
assigned to @ealcantara and unassigned @derek-knox
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ce00e36f and f230f853
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.68 MB 2.68 MB - 0.0 %
Note: We do not have exact data for ce00e36f. So we have used data from: 16d095e2.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Enrique Alcántara
- Resolved by Derek Knox
- Resolved by Derek Knox
assigned to @derek-knox and unassigned @ealcantara
added 290 commits
-
b99d6d2f...5cad762b - 288 commits from branch
master
- 026f8842 - Add toml and json front matter support to SSE
- eab90073 - Apply feedback - add missing error case to spec
-
b99d6d2f...5cad762b - 288 commits from branch
assigned to @ealcantara and unassigned @derek-knox
mentioned in issue #241000 (closed)
assigned to @derek-knox and unassigned @ealcantara
assigned to @ealcantara and unassigned @derek-knox
assigned to @derek-knox and unassigned @ealcantara
mentioned in issue #243608 (closed)
added 1 commit
- f230f853 - Add toml and json front matter support to SSE
mentioned in issue #233472 (closed)
assigned to @vitallium and unassigned @derek-knox
mentioned in commit 48a15e58
mentioned in commit a4a4c50c
added workflowstaging label and removed workflowin dev label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.