GraphQL Iterations - add scopedPath and scopedUrl
What does this MR do?
Add scopedPath
and scopedUrl
to GraphQL IterationType.
These two new fields are meant to be used inside a project query in order to return a path scoped to the project that looks like /path/to/project/-/iterations/inherited/iteration_id
. They return nil
in any other context.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Refs #235156 (closed)
Merge request reports
Activity
changed milestone to %13.3
- Resolved by charlie ablett
- Resolved by charlie ablett
added 1 commit
- b8937819 - GraphQL Iterations - add scopedPath and scopedUrl
removed workflowin dev label
@cablett could I bother you for a review here please?
assigned to @cablett and unassigned @mdelaossa
1 Message This merge request adds or changes files that require a review from the Technical Writing team. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+10, 16 hours ahead of@mdelaossa
)Ash McKenzie ( @ashmckenzie
) (UTC+10, 16 hours ahead of@mdelaossa
)frontend Himanshu Kapoor ( @himkp
) (UTC+5.5, 11.5 hours ahead of@mdelaossa
)Simon Knox ( @psimyn
) (UTC+10, 16 hours ahead of@mdelaossa
)These files couldn't be categorised, so Danger was unable to suggest a reviewer. Please consider creating a merge request to add support for them.
doc/api/graphql/reference/gitlab_schema.graphql
doc/api/graphql/reference/gitlab_schema.json
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3efc769f and bda18c88
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.53 MB 3.53 MB - 0.0 % mainChunk 2.67 MB 2.67 MB - 0.0 %
Note: We do not have exact data for 3efc769f. So we have used data from: 694aac31.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- c083bdd5 - GraphQL Iterations - add scopedPath and scopedUrl
added documentation label
- Resolved by Mario de la Ossa
- Resolved by Mario de la Ossa
- Resolved by Mario de la Ossa
- Resolved by charlie ablett
- Resolved by charlie ablett
Great work @mdelaossa ! Particularly, passing the parent object via
extras
. Shall we start a styleguide update to demonstrate passing a parent object into a child resolver?
- Resolved by charlie ablett
I've left a few minor comments
unassigned @cablett
assigned to @cablett
added 1 commit
- 03fbf352 - GraphQL Iterations - add scopedPath and scopedUrl
added 883 commits
-
03fbf352...2e6e20a9 - 882 commits from branch
master
- bda18c88 - GraphQL Iterations - add scopedPath and scopedUrl
-
03fbf352...2e6e20a9 - 882 commits from branch
mentioned in commit 2dfb7213
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !38821 (merged)
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
added Category:Team Planning label
mentioned in merge request !75001 (merged)