danger-review
Passed Started
by
@mdelaossa

Mario de la Ossa
1Running with gitlab-runner 13.3.0-rc1 (669fc507)2 on prm-com-gitlab-org bd0915564Using Docker executor with image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...5Authenticating with credentials from job payload (GitLab Registry)6Pulling docker image registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...7Using docker image sha256:801b5008096188b1c272fd9ff1964157637cf12981fdb947c49abb4ae943fbe3 for registry.gitlab.com/gitlab-org/gitlab-build-images:danger ...9Running on runner-bd091556-project-278964-concurrent-0 via runner-bd091556-prm-1597780630-4adbbfeb...11$ eval "$CI_PRE_CLONE_SCRIPT"12Downloading archived master...13Connecting to storage.googleapis.com (172.217.204.128:443)14saving to '/tmp/gitlab.tar.gz'15gitlab.tar.gz 24% |******* | 247M 0:00:03 ETA16gitlab.tar.gz 61% |******************* | 612M 0:00:01 ETA17gitlab.tar.gz 99% |******************************* | 999M 0:00:00 ETA18gitlab.tar.gz 100% |********************************| 1001M 0:00:00 ETA19'/tmp/gitlab.tar.gz' saved20Extracting tarball into /builds/gitlab-org/gitlab...21Fetching changes with git depth set to 20...22Reinitialized existing Git repository in /builds/gitlab-org/gitlab/.git/23Created fresh repository.24Checking out f54c5311 as refs/merge-requests/39543/merge...25Skipping Git submodules setup27Checking cache for yarn-v1-3...28Downloading cache.zip from https://storage.googleapis.com/gitlab-com-runners-cache/project/278964/yarn-v1-3 29Successfully extracted cache31$ source scripts/utils.sh32$ retry yarn install --frozen-lockfile33yarn install v1.21.134[1/5] Validating package.json...35[2/5] Resolving packages...36warning Resolution field "ts-jest@24.0.0" is incompatible with requested version "ts-jest@^23.10.5"37success Already up-to-date.38$ node ./scripts/frontend/postinstall.js39success Dependency postinstall check passed.40Done in 1.22s.41$ danger --fail-on-errors=true --verbose42WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.43WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.44WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.45WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.46WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.47WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.48WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.49WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.50WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.51WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.52WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.53WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.54WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.55WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.56WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.57WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.58WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.59WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.60WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.61WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.62WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.63WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.64WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.65WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.66WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.67WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.68WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.69WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.70WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.71WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.72WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.73WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.74WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.75WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.76WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.77WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.78WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.79WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.80WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.81WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.82WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.83WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.84WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.85WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.86WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.87WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.88WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.89WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.90WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.91WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.92WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.93WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.94WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.95WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.96WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.97WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.98WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.99WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.100WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.101WARNING: Please convert ObjectifiedHash object to hash before calling Hash methods on it.102Results:103Messages:104- [ ] This merge request adds or changes files that require a review from the Technical Writing team.105Markdown:106## Documentation review107The following files require a review from a technical writer:108* `doc/api/graphql/reference/index.md`109The review does not need to block merging this merge request. See the:110- [Technical Writers assignments](https://about.gitlab.com/handbook/engineering/technical-writing/#designated-technical-writers) for the appropriate technical writer for this review.111- [Documentation workflows](https://docs.gitlab.com/ee/development/documentation/workflow.html) for information on when to assign a merge request for review.112## Reviewer roulette113Changes that require review have been detected! A merge request is normally114reviewed by both a reviewer and a maintainer in its primary category (e.g.115~frontend or ~backend), and by a maintainer in all other categories.116To spread load more evenly across eligible reviewers, Danger has picked a candidate for each117review slot, based on their timezone. Feel free to118[override these selections](https://about.gitlab.com/handbook/engineering/projects/#gitlab)119if you think someone else would be better-suited, or the chosen person is unavailable.120To read more on how to use the reviewer roulette, please take a look at the121[Engineering workflow](https://about.gitlab.com/handbook/engineering/workflow/#basics)122and [code review guidelines](https://docs.gitlab.com/ee/development/code_review.html).123Please consider assigning a reviewer or maintainer who is a124[domain expert](https://about.gitlab.com/handbook/engineering/projects/#gitlab) in the area of the merge request.125Once you've decided who will review this merge request, mention them as you126normally would! Danger does not automatically notify them for you.127| Category | Reviewer | Maintainer |128| -------- | -------- | ---------- |129| ~backend | [Tiger Watson](https://gitlab.com/tigerwnz) (`@tigerwnz`) (UTC+10, 16 hours ahead of `@mdelaossa`) | [Ash McKenzie](https://gitlab.com/ashmckenzie) (`@ashmckenzie`) (UTC+10, 16 hours ahead of `@mdelaossa`) |130| ~frontend | [Himanshu Kapoor](https://gitlab.com/himkp) (`@himkp`) (UTC+5.5, 11.5 hours ahead of `@mdelaossa`) | [Simon Knox](https://gitlab.com/psimyn) (`@psimyn`) (UTC+10, 16 hours ahead of `@mdelaossa`) |131These files couldn't be categorised, so Danger was unable to suggest a reviewer.132Please consider creating a merge request to134for them.135* `doc/api/graphql/reference/gitlab_schema.graphql`136* `doc/api/graphql/reference/gitlab_schema.json`137**If needed, you can retry the [`danger-review` job](https://gitlab.com/gitlab-org/gitlab/-/jobs/692796436) that generated this comment.**139Not uploading cache yarn-v1-3 due to policy140Job succeeded