Assign alerts sidebar base
What does this MR do?
This is merge 1/2 for: #218404 (closed)
See #218404 (comment 345803729) for progression plan and caveeats.
These three merges are designed to provide the base of the rest of the work for: &3349 (closed)
In this merge we do a handful of things:
- Add the sidebar base to Alert Details
- Migrate Alert Status Dropdown to sidebar
- Style sidebar to match current sidebar designs
- Add the base To Do layout but disable it for now(we can hide this if needed but I think disabled makes more sense).
- Add new specs for the sidebar component and remove status update specs from Alert Details component
We want to provide the most boring possible solution, clearing a clear path to progression in an iteration based approach. This is done by doing to main things:
UX => We attempt to keep this sidebar as close to the current versions as possible in the app. Providing the most amount of constancy and use-ability. Not everything will be perfect but this is just stage 1.
frontend => We opt to let components hold local state, leverage parent <-> child data flow as Vue recommends and break components down as much as possible.
Notes && Known Issues
- To Do UI added but disabled until: #215946 (closed)
- Status dropdown is moved from details page to sidebar
- Sidebar is designed to match current sidebars i.e. full width + collapsable
- There is a error state for failed updates of status
- There is no success state, rather we follow convention and close the dropdown on a successful update
- Icon used for collapsed sidebar => severity-critical. This is a stop gap as I assume we will need to change this?
- Page layout needs a extra class applied to correct padding at right side => follow up MR
- Severity Icon section needs to be added => Follow up MR
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team