Skip to content

Add missing fields to Alert Details view

Tristan Read requested to merge tr-alert-detail-remaining-fields into master

What does this MR do?

This MR adds missing fields to the Alert Details view.

  • description
  • updatedAt
  • details

It also tidies up the graphql queries to make better use of fragments. This changes the order of the results on the page, but since it was already unordered this is ok. I've asked UX here #214550 (comment 344068623) if we want to define an order for these fields.

Issue: #214550 (closed)

Screenshots

before after
Screenshot_2020-05-18_at_15.46.54 Screenshot_2020-05-18_at_15.46.43

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Rémy Coutable

Merge request reports