Skip to content

Deprecate Gitlab UI class-name clashes

Sarah Groff Hennigh-Palermo requested to merge 36857-phase-1 into master

What does this MR do?

This MR renames utility classes that clash with Gitlab UI utility class names. It is part 1 of making Gitlab UI utilities available in Gitlab. It is paired with a Danger update (!30501 (merged)) and will be followed by the MR adding the utilities: !30724 (merged).

The entire process is laid out in #36857

Changes outside scss files generated using repren command

repren -p /path/to/file/repren-deprecate --word-breaks --full ./spec ./ee/spec ./app/assets/javascripts ./app/views ./ee/app/assets/javascripts ./ee/app/views

with the patternfile:

# Deprecate and then replace in next step
(gl-p-[1-9+])	\1-deprecated-no-really-do-not-use-me
(gl-pl-[1-9+])	\1-deprecated-no-really-do-not-use-me
(gl-pr-[1-9+])	\1-deprecated-no-really-do-not-use-me
(gl-pt-[1-9+])	\1-deprecated-no-really-do-not-use-me
(gl-pb-[1-9+])	\1-deprecated-no-really-do-not-use-me
(gl-font-size-20)	\1-deprecated-no-really-do-not-use-me
(gl-line-height-14)	\1-deprecated-no-really-do-not-use-me
# Replace with Gitlab UI name
gl-font-size-large	gl-font-lg
gl-font-size-12	gl-font-sm
gl-font-size-small	gl-font-sm
gl-font-size-14	gl-font-base
gl-font-size-16	gl-font-lg

And then making manual updates in utilities.scss and common.scss.

Does this MR meet the acceptance criteria?

Conformity

Edited by Yorick Peterse

Merge request reports