Skip to content
Snippets Groups Projects

Only make Review App deployment automatic for frontend changes

All threads resolved!

What does this MR do?

This makes Review App deployment and smoke end-to-end run against them automatic for frontend-related changes, and manual otherwise.

For non-frontend changes, people should just have to start the review-build-cng job and the job would automatically play the review-deploy job once finished (e.g. https://gitlab.com/gitlab-org/gitlab/-/jobs/477627203), and the review-deploy job would do the same and automatically play the review-qa-smoke and review-performance jobs once finished.

Does this MR meet the acceptance criteria?

Conformity

Closes #208834 (closed).

Edited by Rémy Coutable

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @caalberts @godfat Could you please review? Thanks!

  • Rémy Coutable assigned to @caalberts and @godfat and unassigned @rymai

    assigned to @caalberts and @godfat and unassigned @rymai

    • Resolved by Rémy Coutable

      @rymai Thanks, I have comments on the frontend-patterns.

      Also, I'm assuming with this change we would have less MRs going through review-qa-smoke, review-performance and dast. I didn't see this being acknowledged anywhere in the issue, so just wanted to clarify that we're ok with it.

      In any case, they have been running with allow_failure: true and dependent on successful review deploy, so they're not a blocking gate.

      Edited by Albert Salim
  • Albert Salim assigned to @rymai and unassigned @caalberts

    assigned to @rymai and unassigned @caalberts

  • Rémy Coutable added 449 commits

    added 449 commits

    Compare with previous version

  • Rémy Coutable added 1 commit

    added 1 commit

    • 347cdade - Only make Review App deployment automatic for frontend changes

    Compare with previous version

  • Lin Jen-Shin
  • Lin Jen-Shin
  • Lin Jen-Shin
  • @rymai Thanks! I agree with the existing comments and just left two more minor thoughts about the names of rules.

  • unassigned @godfat

  • Rémy Coutable added 91 commits

    added 91 commits

    Compare with previous version

  • Rémy Coutable changed the description

    changed the description

  • Rémy Coutable resolved all threads

    resolved all threads

  • Rémy Coutable assigned to @godfat and unassigned @rymai

    assigned to @godfat and unassigned @rymai

  • Lin Jen-Shin assigned to @rymai and unassigned @godfat

    assigned to @rymai and unassigned @godfat

  • Rémy Coutable
  • Rémy Coutable
  • Rémy Coutable added 1 commit

    added 1 commit

    • 44fa3382 - Only make Review App deployment automatic for frontend changes

    Compare with previous version

  • Rémy Coutable assigned to @godfat and unassigned @rymai

    assigned to @godfat and unassigned @rymai

  • Lin Jen-Shin
  • Lin Jen-Shin approved this merge request

    approved this merge request

  • Lin Jen-Shin resolved all threads

    resolved all threads

  • Lin Jen-Shin enabled an automatic merge when the pipeline for 287976d5 succeeds

    enabled an automatic merge when the pipeline for 287976d5 succeeds

  • merged

  • Lin Jen-Shin mentioned in commit 80710af9

    mentioned in commit 80710af9

  • added workflowcanary label and removed workflowstaging label

  • mentioned in issue #211579 (closed)

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #205307 (closed)

  • Kyle Wiebers mentioned in merge request !27926 (closed)

    mentioned in merge request !27926 (closed)

  • mentioned in issue #30140 (closed)

  • Please register or sign in to reply
    Loading