Use Review Apps for frontend related changes
Problem Statement
Review Apps provide a method of deploying an entire GitLab instance for testing against an environment with the changes from the MR. Review Apps is quality enabler and will be improved with #25297 (closed) to enable more data within a Review App environment.
Engineering Productivity should continue to refine Review Apps to deploy them when they are most useful to help balance out stability and cost with the value towards quality.
Definitions
- Review App jobs - currently extend
.review:rules:mr-and-schedule
configuration:review-build-cng
,review-deploy
,review-stop
,review-qa-smoke
, andreview-performance
Proposal
- Reduce Review App jobs to UX related changes and manual for all code non-UX changes. Patterns are:
- "{package.json,yarn.lock}" - "{babel.config,jest.config}.js" - ".csscomb.json" - "Dockerfile.assets" - "vendor/assets/**/*" - "{,ee/}{app/assets,app/helpers,app/presenters,app/views,locale,public,symbol}/**/*"
- All other code-qa patterns will allow for Review App jobs to be manually triggered.
Concerns/Counterpoints
- Fragmenting our changes logic further introduces brittle configuration that is challenging to test for and make future enhancements.