Draft: [skip ci] Remove the mr_pipelines_graphql feature flag

What does this MR do and why?

This MR removes the mr_pipelines_graphql feature flag. It is stacked on !266580, which moves the new merge request page to a GraphQL list behind the same flag.

The flag is enabled by default since !263880 (merged). After this MR, the Pipelines tab always renders a GraphQL list:

  • The existing merge request page renders pipelines_table_wrapper.vue. Projects::MergeRequestsController no longer pushes the flag.
  • The new merge request page renders new_merge_request_pipelines_list.vue, whenever gl.mrWidgetData is missing. Projects::MergeRequests::CreationsController no longer pushes the flag.

No production code reaches these modules now, so the MR deletes them and their specs:

  • commit/pipelines/legacy_pipelines_table_wrapper.vue
  • commit/pipelines/legacy_pipelines_store.js
  • commit/pipelines/legacy_pipelines_service.js
  • commit/pipelines/legacy_pipelines_mixin.js

The MR also removes two exports that only the legacy wrapper used:

  • CREATING_PIPELINE_TOAST_MESSAGE is deleted. Its string stays in locale/gitlab.pot, because the MR widget uses the same string.
  • validateParams is no longer exported. Its own module still uses it.

Knip confirmed this list. The check used the script from !265759 (merged), with only the webpack entry points as entries.

The existing merge request page app no longer chooses a table wrapper: it always loads pipelines_table_wrapper.vue, and it drops the endpoint and isMergeRequestTable props that only the legacy wrapper read.

The MR also removes the legacy wrapper from .eslint_todo/local-rules-vue-no-single-use-i-18-n-keys.mjs.

Most of the diff is deleted files. In the feature specs, select Hide whitespace changes: the only change there is that the examples no longer run twice, with the flag on and off.

How knip was run
  1. Run the script on all of app/assets/javascripts and ee/app/assets/javascripts on master. This is the baseline.
  2. Run it again with the flag removed. It reports 6 new findings: the 4 modules above and the 2 exports.
  3. Delete them and run it again. It reports no new findings.
  4. After the rebase onto !266580, compare the stack tip with master and with !266580. Neither comparison has a new finding.

Each run compares the findings with the baseline, so findings that already exist on master do not count.

Not in this MR

  • The pipelines table rows still accept REST-shaped rows. The next MR removes those fallbacks: !266262
  • No frontend code calls the REST pipelines JSON actions in Projects::MergeRequestsController and Projects::MergeRequests::CreationsController now. No frontend code reads the data-endpoint attribute in projects/commit/_pipelines_list.haml either. Knip does not see HAML, so this was checked by hand. Removing them needs backend review, so they are left for #637015.

Screenshots or screen recordings

No visual change is intended. The flag was already enabled by default.

How to set up and validate locally

  1. Open the Pipelines tab of a merge request that has pipelines. The GraphQL table renders.
  2. Start a new merge request from a branch with pipelines on more than one commit. Open its Pipelines tab. The GraphQL table lists the pipelines of every commit.
  3. On each page, select another tab and then Pipelines again. The table renders once.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Local verification
  • Jest passes at the tip of the stack for spec/frontend/ci/common, spec/frontend/ci/merge_requests, spec/frontend/ci/pipelines_page and spec/frontend/merge_request_tabs_spec.js.
  • merge_request_tabs_spec.js and pipelines_table_wrapper_spec.js also pass in the Vue 3 lane.
  • ESLint, Prettier and the lefthook pre-push checks pass.
  • The feature specs were not run locally. CI runs them:
    • user_sees_pipelines_spec.rb
    • user_sees_merge_request_pipelines_spec.rb
    • user_sees_pipelines_from_forked_project_spec.rb
    • user_selects_branches_for_new_mr_spec.rb

References

Edited by Miguel Rincon

Merge request reports

Loading
Loading