Remove the commit_pipelines_tab_graphql feature flag
What does this MR do and why?
Removes the commit_pipelines_tab_graphql feature flag. The commit details Pipelines tab now always renders the GraphQL-backed CommitPipelinesList component, and the REST fallback branch is gone from the mount code.
Changes:
- Deletes
config/feature_flags/wip/commit_pipelines_tab_graphql.yml. - Drops the
push_frontend_feature_flagbefore_actionfromProjects::CommitController. - Drops the
Feature.enabled?guard inGraphqlTriggers.ci_pipeline_statuses_updated, making the two sha-scopedci_pipeline_statuses_updatedtriggers unconditional. These are what drive the tab's real-time updates, so the flag removal is incomplete without this. - Collapses the
gon.features.commitPipelinesTabGraphqlternary inpipelines_bundle.jsto a static import, and drops theendpointprop, which only the legacy component consumed. - Collapses the flag on/off duplication in
graphql_triggers_spec.rbanduser_sees_pipelines_tab_spec.rb.
The legacy component tree is intentionally kept
legacy_pipelines_table_wrapper.vue (and legacy_pipelines_store / legacy_pipelines_service / legacy_pipelines_mixin) are not deleted here. They are still the fallback for the merge request Pipelines tab, behind the separate mr_pipelines_graphql flag (app/assets/javascripts/merge_request_tabs.js). Deleting them belongs to that flag's own removal.
For the same reason, data-endpoint stays on #commit-pipeline-table-view: app/views/projects/commit/_pipelines_list.haml is shared with the merge request views, where merge_request_tabs.js still reads it.
Drive-by: initVueApp
The mount code moves to initVueApp from ~/lib/utils/vue3compat/init_vue_app.
One thing worth a reviewer's eye: initVueApp replaces its mount element, whereas the previous code did $mount() + appendChild. initPipelineCountListener attaches to #commit-pipeline-table-view and receives a bubbling update-pipelines-count event from the component, so mounting directly on that element would detach the listener and silently break the tab's count badge. The app therefore mounts on a child element, preserving the previous DOM shape.
How to verify
-
Visit a commit that has pipelines: Repository > Commits > (a commit) > Pipelines.
-
The pipelines table renders, with the mini graph and the manual/multi-action dropdowns.
-
The tab label shows the pipeline count, for example
Pipelines 1— this exercises theupdate-pipelines-countpath described above.
-
With a running pipeline on that commit, its status updates without a page reload, and a newly created pipeline for the same SHA appears at the top of the list. This exercises the now-unconditional sha-scoped subscription triggers.
-
Regression check: on a merge request's Pipelines tab with
mr_pipelines_graphqldisabled, the legacy table still renders.
Covered automatically by spec/features/projects/commit/user_sees_pipelines_tab_spec.rb, which asserts steps 2 through 4.
Test results
Run locally:
yarn jest spec/frontend/ci/commit spec/frontend/commit/pipelines— 3 suites, 67 tests passing. The legacy wrapper spec passing confirms the shared component tree was left intact.yarn eslint app/assets/javascripts/commit/pipelines/pipelines_bundle.js— clean.bundle exec rubocopon the four changed Ruby files — no offenses.- Repo-wide grep for the flag name in both snake_case and camelCase returns no matches.
RSpec suites were not run locally and are left to CI.
References
- Rollout: #604986 (closed)
- Feature: #603006 (closed)
- Follow-up, removing the legacy tree with the other flag: #419726
